1ES Template Conversion #28848
Merged
1ES Template Conversion #28848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
requested review from
ckairen,
mikeharder,
weshaggard,
benbp,
timovv,
maorleger,
a team,
miguhern,
whisper6284,
RoyHerrod and
danielav7
as code owners
github-actions
bot
added
Communication - Phone Numbers
EngSys
|
API change check API changes are not detected in this pull request. |
|
Keyvault failures seem unrelated, Matt has a fix here: #28863 |
benbp
reviewed
Mar 11, 2024
benbp
reviewed
Mar 11, 2024
scbedd
force-pushed
the
1es-template-conversion
branch
from
e813f3d
to
6492b58
Compare
azure-sdk
approved these changes
Mar 11, 2024
benbp
approved these changes
Mar 11, 2024
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Appreciate the heads up! |
xirzec
reviewed
Mar 12, 2024
| echo "##vso[task.setvariable variable=Package.Archive]$detectedPackageName" | ||
| if ('$(Build.Repository.Name)' -eq 'Azure/azure-sdk-for-js') { | ||
| $npmToken="$(azure-sdk-npm-token)" | ||
| $registry=${{parameters.Registry}}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the culmination of the last couple weeks of work to transition pipelines. Python was our first repo migrated, and I haven't seen anything ship stopping from them yet!
If you see fallout due to this merge, please @ me on the teams thread.
A follow-up commit like this one in python will be commit directly after merging this PR. This will update all
tests.ymlusage to align with what is necessary from THIS PR. These changes are not included to avoid a build storm.