[core-client] Fix issue with Storage bearer challenges #28967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
requested review from
jeremymeng,
deyaaeldeen,
timovv and
mpodwysocki
as code owners
xirzec
added
Client
|
API change check API changes are not detected in this pull request. |
mpodwysocki
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/core-clientDescribe the problem that is addressed by this PR
When this logic was ported from a Storage-specific policy, it referenced a field in the challenge called
resource_uriinstead of the actual value which isresource_id.You can see the working value in the storage/stable branch:
azure-sdk-for-js/sdk/storage/storage-blob/src/policies/StorageBearerTokenChallengeAuthenticationPolicy.ts
Line 252 in f7fca7e
I suspect the reason for the confusion is because the documentation page that describes this feature incorrectly gives an example that has
resource_urieven though the parameter description listsresource_id: https://learn.microsoft.com/en-us/rest/api/storageservices/authorize-with-azure-active-directory#sample-response-to-bearer-challengeThis wasn't caught previously as Storage had not migrated to CoreV2 and exercised this codepath.