Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-amqp] Move to ESM/vitest #29303

Merged
merged 17 commits into from
May 6, 2024
Merged

[core-amqp] Move to ESM/vitest #29303

merged 17 commits into from
May 6, 2024

Conversation

mpodwysocki
Copy link
Member

@mpodwysocki mpodwysocki commented Apr 12, 2024

Packages impacted by this PR

  • @azure/core-amqp

Describe the problem that is addressed by this PR

Moves @azure/core-amqp to ESM via tshy and unit tests from mocha to vitest.

sdk/core/core-amqp/package.json Show resolved Hide resolved
sdk/core/core-amqp/src/errors.ts Outdated Show resolved Hide resolved
@jeremymeng
Copy link
Member

/azp run js - service-bus - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the migration!

sdk/core/core-amqp/package.json Outdated Show resolved Hide resolved
sdk/core/core-amqp/package.json Outdated Show resolved Hide resolved
@mpodwysocki mpodwysocki enabled auto-merge (squash) May 6, 2024 00:20
@mpodwysocki mpodwysocki merged commit 99026aa into main May 6, 2024
14 checks passed
@mpodwysocki mpodwysocki deleted the feat/amqp-esm branch May 6, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants