[core-http] Report progress after pushing data #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were reporting the progress before data is pushed. This leads to customer reported issue like Azure#4719 where the uploaded progress events are triggered before data chunks are completely uploaded. This change introduces a `ReportStream` that provides the correct `_transform` behavior.
jeremymeng
requested review from
daviwil,
HarshaNalluru,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
HarshaNalluru
approved these changes
Sep 30, 2019
daviwil
approved these changes
Sep 30, 2019
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Dec 5, 2019
The regression was introduced in Azure#5298. If a second argument `data` is passed to `callback()` in `_transform()`, `data` will be pushed again. I misread the doc when adding the report transform. This change removes the second argument from `callback()`. Fixes Azure#6352.
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Dec 5, 2019
The regression was introduced in Azure#5298. If a second argument `data` is passed to `callback()` in `_transform()`, `data` will be pushed again. I misread the doc when adding the report transform. This change removes the second argument from `callback()`. Fixes Azure#6352.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were reporting the progress before data is pushed. This leads to customer
reported issue like
#4719
where the uploaded progress events are triggered before data chunks are
completely uploaded.
This change introduces a
ReportStreamthat provides the correct_transformbehavior.