Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmos] Use rushx instead of rush in the CI steps specific to Cosmos #5349

Merged
merged 3 commits into from
Oct 2, 2019
Merged

[Cosmos] Use rushx instead of rush in the CI steps specific to Cosmos #5349

merged 3 commits into from
Oct 2, 2019

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Oct 2, 2019 •
edited
Loading

Issue - #5350

cc - @joheredi

@HarshaNalluru HarshaNalluru self-assigned this Oct 2, 2019
@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. Cosmos EngSys This issue is impacting the engineering system. and removed Client This issue points to a problem in the data-plane of the library. labels Oct 2, 2019
danieljurek
danieljurek approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This looks like the only place where we use rushx in our pipelines and the usage is scoped to this package-specific work.

@HarshaNalluru HarshaNalluru merged commit b2732ee into Azure:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljurek danieljurek danieljurek approved these changes

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya

@mikeharder mikeharder Awaiting requested review from mikeharder

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@weshaggard weshaggard Awaiting requested review from weshaggard

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees

@HarshaNalluru HarshaNalluru

Labels
Cosmos EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarshaNalluru @danieljurek