Add tracing to storage-file #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
added
Client
jeremymeng
reviewed
Oct 3, 2019
| metadata: options.metadata, | ||
| filePermission: options.filePermission, | ||
| filePermissionKey: options.filePermissionKey | ||
| const { span, spanOptions } = createSpan("DirectoryClient-create", options.spanOptions); |
There was a problem hiding this comment.
I am missing C# nameof feature already...
This reverts commit e6ba907. Issues running browser tests with tracing policy.
HarshaNalluru
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dependency on @azure/core-tracing and makes it possible to pass a parent
Spanto public facing operations.Also included are a couple small tests that validate Spans are being created properly.