Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev dependency "prettier" #9325

Closed
wants to merge 2 commits into from

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Jun 5, 2020

Overview

I tried updating to prettier@^2.0.5, but when I execute npm run format, there are a ton of formatting changes. Examples include:

In order to upgrade, I think we will need to either modify our config to make prettier@2 work more closely to prettier@1, or we will need to reformat nearly all our source files.

Breaking Changes

https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

Relevant breaking changes:

  • Drop support for Node versions older than 10
    • Probably OK since we only build on Node 10 and above. Node 8 is only used for testing.
  • Change default value for trailingComma to es5
  • Change default value for arrowParens to always
    • Already set to this value in our config
  • Change default value for endOfLine to lf
    • Already set to this value in our config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant