Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processor lifecycle changes #14714

Closed
JoshLove-msft opened this issue Aug 31, 2020 · 0 comments · Fixed by #14773
Closed

Processor lifecycle changes #14714

JoshLove-msft opened this issue Aug 31, 2020 · 0 comments · Fixed by #14773
Assignees
@JoshLove-msft
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@JoshLove-msft
Copy link
Member

  • Add explicit Close methods taking a CloseMode enum that currently just has one value (Detach). In the future, this list will grow as the service adds support for Drain and durable terminus. This should be added to Sender/Receiver/Processor/SessionProcessor.
  • Implement IAsyncDisposable for consistency with sender/receiver.
  • StopProcessing should not actually close links - it should stop receiving messages though. It should continue to wait for in-flight processing to complete.
  • DisposeAsync should call CloseAsync with the default CloseMode of Detach.
@JoshLove-msft JoshLove-msft added Service Bus Client This issue points to a problem in the data-plane of the library. labels Aug 31, 2020
@JoshLove-msft JoshLove-msft self-assigned this Aug 31, 2020
@JoshLove-msft JoshLove-msft mentioned this issue Sep 1, 2020
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Jun 21, 2021
CodeGen from PR 14714 in Azure/azure-rest-api-specs
f60dea0 
Adding iperf APIs (Azure#14714)

* Adding iperf APIs

* Addressing review comments

* Addressing PR comments

* Removing APIs unimplemented in Sterling

* Fixing resource schemas

* Fixing linting errors
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshLove-msft JoshLove-msft

Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lifecycle updates JoshLove-msft/azure-sdk-for-net
1 participant
@JoshLove-msft