Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate PrefetchSizeInBytes Option #15098

Closed
jsquire opened this issue Sep 11, 2020 · 0 comments
Closed

Integrate PrefetchSizeInBytes Option #15098

jsquire opened this issue Sep 11, 2020 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs

Comments

@jsquire
Copy link
Member

jsquire commented Sep 11, 2020

Summary

As part of an exploratory effort, an option for tuning Event Hub consumer clients using a size-limited prefetch cache provided by the Microsoft.Azure.Amqp library was prototyped and released for partner testing. The prototype functionality has been confirmed, and the options should be integrated into the main branch of the repository for inclusion in future releases.

Scope of Work

  • Review the prototype API with the .NET language architect and seek formal approval for its addition.

  • Incorporate the changes from the prototype into the main branch of the repository, addressing comments left on the pull request as part of that integration.

  • Review the behavior details provided by the Event Hubs service team and ensure that relevant API members are documented as appropriate for public options. (details provided as part of an internal email thread)

Success Criteria

  • The API changes have been reviewed and approved by the .NET architect.

  • The API surface needed to support the PrefetchSizeInBytes feature has been implemented by applying the prototype changes.

  • The feedback from the prototype pull request has been addressed and incorporated.

  • The tests necessary for validation of the feature have been created or adjusted and pass reliably.

  • The existing live test suite continues to produce deterministic results and pass reliably.

References

@jsquire jsquire added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Sep 11, 2020
@jsquire jsquire added this to the [2020] October milestone Sep 11, 2020
@jsquire jsquire self-assigned this Sep 11, 2020
@jsquire jsquire closed this as completed Sep 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

1 participant