[Event Hubs Client] Prefetch Size In Bytes Option #15141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
jsquire
requested review from
kinelski,
KrzysztofCwalina,
pakrym,
serkantkaraca and
tg-msft
as code owners
The focus of these changes is to introduce an option for the various event consumers allowing the prefetch cache to be filled based on a size-based heuristic rather than a count of events. This feature is considered a special case, helpful in scenarios where the size of events being read is not able to be known or predicted upfront and limiting resource use is valued over consistent and predictable performance.
jsquire
force-pushed
the
release/eventhubs-5.2.0b1
branch
from
ba32ecb
to
ea393b6
Compare
|
/azp run net - eventhub - tests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Manual run of the full suite taking place on the internal pipeline: #536700 |
christothes
approved these changes
Sep 15, 2020
| { | ||
| if (value.HasValue) | ||
| { | ||
| Argument.AssertAtLeast(value.Value, 0, nameof(PrefetchSizeInBytes)); |
There was a problem hiding this comment.
Oddly enough, yes. That will have the net effect of "always prefetch exactly one event no matter the size",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to introduce an option for the various event consumers allowing the prefetch cache to be filled based on a size-based
heuristic rather than a count of events. This feature is considered a special case, helpful in scenarios where the size of events being read is not able to be known or predicted upfront and limiting resource use is valued over consistent and predictable performance.
Note: These API changes are part of a preview feature. The design and API surface were informally reviewed with the language architect but have not yet undergone formal review with the architecture board. I expect some changes, particularly around naming.
Last Upstream Rebase
Monday, September 14, 9:07am (EDT)
References and Related Issues