Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.Analytics.Synapse.ManagedPrivateEndpoints Readme issues #17668

Closed
Tianyun-G opened this issue Dec 22, 2020 · 0 comments · Fixed by #17682
Closed

Azure.Analytics.Synapse.ManagedPrivateEndpoints Readme issues #17668

Tianyun-G opened this issue Dec 22, 2020 · 0 comments · Fixed by #17682
Assignees
@chamons
Labels
Client This issue points to a problem in the data-plane of the library. Docs needs-team-triage Workflow: This issue needs the team to triage. Synapse test-manual-pass
Milestone
MQ-2020

Comments

@Tianyun-G
Copy link
Contributor

Section link:
image
Suggestion:Add [nuget]: https://www.nuget.org/

Section link:
image
Suggestion:

1.Add [azure_sub]: https://azure.microsoft.com/free/

2.Add hyperlink for Azure Portal: https://portal.azure.com/

3.Add [azure_cli]: https://docs.microsoft.com/cli/azure

Section link:
image
Suggestion:

1.Update [ManagedPrivateEndpointClient][managed_priate_endpoint_client_class] to [ManagedPrivateEndpointsClient][managed_priate_endpoints_client_class]
And add [managed_priate_endpoints_client_class]: https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/synapse/Azure.Analytics.Synapse.ManagedPrivateEndpoints/src/Customization/ManagedPrivateEndpointsClient.cs

2.Add [azure_identity]: https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/identity/Azure.Identity

3.Add [DefaultAzureCredential]: https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/identity/Azure.Identity#defaultazurecredential

Section link:
image
Suggestion: Update ManagedPrivateEndpointClient to ManagedPrivateEndpointsClient

@jongio for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 22, 2020
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Docs needs-team-triage Workflow: This issue needs the team to triage. Synapse labels Dec 22, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 22, 2020
@chamons chamons added this to the MQ-2020 milestone Dec 22, 2020
chamons added a commit to chamons/azure-sdk-for-net that referenced this issue Dec 22, 2020
@chamons
[synapse] Fix many README links
a3c52e3 
- Fixes Azure#17666
- Fixes Azure#17667
- Fixes Azure#17668
- Fixes Azure#17669
- Fixes Azure#17670
@chamons chamons mentioned this issue Dec 22, 2020
Merged
chamons added a commit that referenced this issue Dec 22, 2020
@chamons
[synapse] Fix many README links (#17682)
24ef4e7 
- Fixes #17666
- Fixes #17667
- Fixes #17668
- Fixes #17669
- Fixes #17670
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this issue Feb 17, 2021
@chamons @annelo-msft
[synapse] Fix many README links (Azure#17682)
31c5e6c 
- Fixes Azure#17666
- Fixes Azure#17667
- Fixes Azure#17668
- Fixes Azure#17669
- Fixes Azure#17670
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chamons chamons

Labels
Client This issue points to a problem in the data-plane of the library. Docs needs-team-triage Workflow: This issue needs the team to triage. Synapse test-manual-pass
Projects
None yet
Milestone
MQ-2020
Development

Successfully merging a pull request may close this issue.

[synapse] Fix many README links chamons/azure-sdk-for-net
4 participants
@jsquire @chamons @tzhanl @Tianyun-G