[Identity] Update SP credentials to use MSAL confidential client #13168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaabs
requested review from
KrzysztofCwalina,
pakrym and
tg-msft
as code owners
|
/azp run net - identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| /// <param name="clientSecret">A client secret that was generated for the App Registration used to authenticate the client.</param> | ||
| /// <param name="options">Options that allow to configure the management of the requests sent to the Azure Active Directory service.</param> | ||
| public ClientSecretCredential(string tenantId, string clientId, string clientSecret, ClientSecretCredentialOptions options) | ||
| : this(tenantId, clientId, clientSecret, (TokenCredentialOptions)options) |
There was a problem hiding this comment.
Why this cast (TokenCredentialOptions)options is required?
There was a problem hiding this comment.
I added it because I wanted to be explicit about calling the overload which take TokenCredential. Perhaps it's not needed if this(*) will never recurse.
|
APIs look good. |
| } | ||
| } | ||
|
|
||
| private async ValueTask EnsureInitializedAsync(bool async) |
There was a problem hiding this comment.
Do we need CancellationToken here?
There was a problem hiding this comment.
After offline discussion of this I created a backlog issue to improve this #13201 once support is available in Azure.Core
AlexanderSher
approved these changes
Jul 2, 2020
weshaggard
reviewed
Jul 2, 2020
|
/azp run net - identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-net
that referenced
this pull request
Feb 26, 2021
Users/mayaggar/dataprotection (Azure#13168) * New Readme Config File * New Go Language Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New AzureResourceSchema Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Microsoft.data protection (Azure#12814) * moving changes from Private repo * changes for autorest vqalidation err * fix delete response * fixing lint and model errors * exposureControlledFeatures fixes * prettier fixes * fixing spell check issues * adding backuptype in custom-words * PolicyParameters related changes for Disk Backup * fixing PR comments * description changes * changes for preview to stable folder * changes for retention in monitoring * changes for stable in readme * fixing checklist gate issues * changes for systemdata in dppresource Co-authored-by: sumitmal <32121310+sumitmal@users.noreply.github.com> Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: vityagi <vityagi@microsoft.com> * MFA MUA DPP swagger changes (Azure#13081) * MFA MUA DPP swagger changes * Resolving PR comments Co-authored-by: Madhumanti Dey <madhude@microsoft.com> * Swagger changes for VaultGuardResource Object (Azure#13116) * MFA MUA DPP swagger changes * Resolving PR comments * MFA MUA dpp swagger changes * Fixed preetierCheck failures * Fixed Avocado failures * Fixed LintDiff warning * resolved PR comments * GO SDK fix * Go SDK fix * Go SDK fix * preview related changes * Go SDK fix * resolved PR comments Co-authored-by: Madhumanti Dey <madhude@microsoft.com> * changes for preview DPP version * fix for credscan SAS Co-authored-by: sumitmal2711 <58544969+sumitmal2711@users.noreply.github.com> Co-authored-by: sumitmal <32121310+sumitmal@users.noreply.github.com> Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> Co-authored-by: vityagi <vityagi@microsoft.com> Co-authored-by: deymadhumanti <58032062+deymadhumanti@users.noreply.github.com> Co-authored-by: Madhumanti Dey <madhude@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.