Add EventGrid samples and readme #15461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
requested review from
ahamad-MS,
chidozieononiwu,
danieljurek,
Kishp01,
mitchdenny and
weshaggard
as code owners
ghost
added
the
kasobol-msft
approved these changes
Sep 25, 2020
sdk/eventgrid/Microsoft.Azure.WebJobs.Extensions.EventGrid/README.md
Outdated
Show resolved
Hide resolved
pakrym
commented
Sep 25, 2020
sdk/eventgrid/Microsoft.Azure.WebJobs.Extensions.EventGrid/README.md
Outdated
Show resolved
Hide resolved
ellismg
approved these changes
Sep 25, 2020
sdk/eventgrid/Microsoft.Azure.WebJobs.Extensions.EventGrid/README.md
Outdated
Show resolved
Hide resolved
pakrym
commented
Sep 25, 2020
sdk/eventgrid/Microsoft.Azure.WebJobs.Extensions.EventGrid/README.md
Outdated
Show resolved
Hide resolved
ellismg
reviewed
Sep 25, 2020
| @@ -42,7 +43,7 @@ internal EventGridExtensionConfigProvider(Func<EventGridAttribute, IAsyncCollect | |||
| // default constructor | |||
| public EventGridExtensionConfigProvider(ILoggerFactory loggerFactory) | |||
| { | |||
| _converter = (attr => new EventGridAsyncCollector(new EventGridPublisherClient(new Uri(attr.TopicEndpointUri), new EventGridSharedAccessSignatureCredential(attr.TopicKeySetting)))); | |||
| _converter = (attr => new EventGridAsyncCollector(new EventGridPublisherClient(new Uri(attr.TopicEndpointUri), new AzureKeyCredential(attr.TopicKeySetting)))); | |||
There was a problem hiding this comment.
Unrelated to this PR: Is there something we could have done in the EventGrid SDK Documentation itself to make it clear which of these you needed to use?
There was a problem hiding this comment.
We have a comment from ApiView about a potential rename of the type to include SAS in the name. Not sure if that would have helped.
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-net
that referenced
this pull request
Aug 3, 2021
Alias description change (Azure#15461)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @kasobol-msft @fabiocav