Sync eng/common directory with azure-sdk-tools for PR 1163 #16707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
azure-sdk
added
Central-EngSys
azure-sdk
force-pushed
the
sync-eng/common-benbp/new-subscription-configuration-1163
branch
from
1e1673d
to
9431174
Compare
benbp
approved these changes
Nov 9, 2020
azure-sdk
force-pushed
the
sync-eng/common-benbp/new-subscription-configuration-1163
branch
2 times, most recently
from
673f553
to
7f29c60
Compare
…ified hash literal
azure-sdk
force-pushed
the
sync-eng/common-benbp/new-subscription-configuration-1163
branch
from
7f29c60
to
db82d5a
Compare
benbp
deleted the
sync-eng/common-benbp/new-subscription-configuration-1163
branch
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
* Update subscription configuration schema to include new parameters * Support platform specific arm template parameters and legacy hashtable format * Update arm template parameter comment to include top level key * Restore AdditionalParameters. Merge ArmTemplateParameters from stringified hash literal * Handle duplicate keys more explicitly for arm and env vars * Regenerate New-TestResources.ps1 markdown * revert variable name to environmentVariables to fix post-scripts * Handle empty arm template parameters better * Remove arm template parameter merge logic from deploy template * Add merge hashes function to New-TestResources.ps1 * Add merge hashes function to New-TestResources.ps1 * Add env variable overwrite warning. Use ContainsKey checks * Temporarily manually fix invalid generated markdown links Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1163 See eng/common workflow