-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Storage for release #16832
Prepare Storage for release #16832
Conversation
@@ -1,3 +1,4 @@ | |||
# Release History | |||
|
|||
## 5.0.0-beta.1 (Unreleased) | |||
## 5.0.0-beta.1 (2020-11-10) | |||
- First release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT - Should this have the same description as the other WebJobs Changelogs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, but let's just use this:
This is the first preview of the next generation of `Microsoft.Azure.WebJobs.Extension.Storage` which has been integrated with latest Azure Storage SDK that follows the [Azure SDK Design Guidelines for .NET](https://azure.github.io/azure-sdk/dotnet_introduction.html) which provide a number of core capabilities that are shared amongst all Azure SDKs, including the intuitive Azure Identity library, an HTTP Pipeline with custom policies, error-handling, distributed tracing, and much more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for reference: this package doesn't go to nuget today. it's all shared source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
## 12.6.0-preview.2 (Unreleased) | ||
|
||
## 12.6.0 (2020-11-10) | ||
- This release contains bug fixes to improve quality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weren't there new SAS features added to Common?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only new thing added to Common was a new constructor for AccountSasBuilder
, so AccountSasBuilder(permissions, expiresON, services, resourceTypes)
. It was more for ease of the customer knowing what's the minimum requirements to create a SAS and to construct the SASs from the Service Clients. It's not really a new feature.
@@ -1,6 +1,6 @@ | |||
# Release History | |||
|
|||
## 5.0.0-beta.1 (Unreleased) | |||
## 5.0.0-beta.1 (2020-11-10) | |||
|
|||
This is the first preview of the next generation of `Microsoft.Azure.WebJobs.Extension.Storage` which has been integrated with latest Azure Storage SDK that follows the [Azure SDK Design Guidelines for .NET](https://azure.github.io/azure-sdk/dotnet_introduction.html) which provide a number of core capabilities that are shared amongst all Azure SDKs, including the intuitive Azure Identity library, an HTTP Pipeline with custom policies, error-handling, distributed tracing, and much more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this say .Storage.Queues
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sentence refers to the past where Microsoft.Azure.WebJobs.Extension.Storage
wasn't split.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog mentions the split further down.
@@ -1,6 +1,6 @@ | |||
# Release History | |||
|
|||
## 5.0.0-beta.1 (Unreleased) | |||
## 5.0.0-beta.1 (2020-11-10) | |||
|
|||
This is the first preview of the next generation of `Microsoft.Azure.WebJobs.Extension.Storage` which has been integrated with latest Azure Storage SDK that follows the [Azure SDK Design Guidelines for .NET](https://azure.github.io/azure-sdk/dotnet_introduction.html) which provide a number of core capabilities that are shared amongst all Azure SDKs, including the intuitive Azure Identity library, an HTTP Pipeline with custom policies, error-handling, distributed tracing, and much more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this say .Storage.Blobs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sentence refers to the past where Microsoft.Azure.WebJobs.Extension.Storage
wasn't split.
No description provided.