[FR] Update service version, TODO cleanup, and add missing xxOperation tests #17387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
kinelski
approved these changes
Dec 7, 2020
sdk/formrecognizer/Azure.AI.FormRecognizer/src/FormRecognizerClientOptions.cs
Outdated
Show resolved
Hide resolved
sdk/formrecognizer/Azure.AI.FormRecognizer/tests/Models/OperationsMockTests.cs
Outdated
Show resolved
Hide resolved
sdk/formrecognizer/Azure.AI.FormRecognizer/src/CopyModelOperation.cs
Outdated
Show resolved
Hide resolved
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
…n tests (Azure#17387) * service version and easy TODO cleanup * parameter validation avoiding breaking changes * add missing tests * update docstring * remove checks that throw in other methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1-preview.2Fixes: Update service version to 2.1-preview.2 #17339xxOperationtests. Fixes: Add missing tests for Operations #17344xxOperationclasses.Note that in order to avoid breaking changes somestringparameters couldn't be validated for empty values mostly because current behavior throws aFormatExceptionand new behavior will throw aArgumentException.After talking with architects, I am going to make a separate PR to make those breaking changes and will discuss in next arch board for FR ( issue: Arch board approval #17383 ).
Note not all validations are added as some create breaking changes and need to be discussed in an arch board meeting. Issue tracking all scenarios is Arch board approval #17383