Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[synapse] Re-enable many disabled tests by bumping to swagger with nullability fix #17645

Merged
merged 3 commits into from
Dec 21, 2020
Merged

[synapse] Re-enable many disabled tests by bumping to swagger with nullability fix #17645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecf15ff
Bump synapse swagger to ca0ac888f84b97feaef05fad6632f41ef1a399e6
chamons Dec 18, 2020
01cb437
Regenerate code from swagger bump
chamons Dec 18, 2020
1b9fa88
Re-enable all tests failing from nullability
chamons Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/synapse/Azure.Analytics.Synapse.AccessControl/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Run `dotnet build /t:GenerateCode` to generate code.
> see https://aka.ms/autorest

```yaml
repo: https://github.com/Azure/azure-rest-api-specs/blob/eea7c0141c0b7ad9f66f8ba06560b549c6b3b014
repo: https://github.com/Azure/azure-rest-api-specs/blob/ca0ac888f84b97feaef05fad6632f41ef1a399e6
```

``` yaml
Expand Down
13 changes: 10 additions & 3 deletions ...apse/Azure.Analytics.Synapse.Artifacts/src/Generated/Models/NotebookCell.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 10 additions & 3 deletions .../Azure.Analytics.Synapse.Artifacts/src/Generated/Models/NotebookMetadata.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...se/Azure.Analytics.Synapse.Artifacts/src/Generated/Models/SparkScheduler.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Run `dotnet build /t:GenerateCode` to generate code.
> see https://aka.ms/autorest

```yaml
repo: https://github.com/Azure/azure-rest-api-specs/tree/eea7c0141c0b7ad9f66f8ba06560b549c6b3b014
repo: https://github.com/Azure/azure-rest-api-specs/tree/ca0ac888f84b97feaef05fad6632f41ef1a399e6
```

``` yaml
Expand Down
1 change: 0 additions & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/NotebookClientLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ public NotebookClientLiveTests(bool isAsync) : base(isAsync)
{
}

[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
[Test]
public async Task TestGetNotebook()
{
Expand Down
1 change: 0 additions & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/samples/NotebookSampleSnippets.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace Azure.Analytics.Synapse.Artifacts.Samples
{
public partial class NotebookSnippets : SampleFixture
{
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
[Test]
public async Task NotebookSample()
{
Expand Down
1 change: 0 additions & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/samples/Sample2_CreateNotebook.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace Azure.Analytics.Synapse.Samples
/// </summary>
public partial class NotebookSample
{
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
[Test]
public async Task CreateAndUploadNotebook()
{
Expand Down
2 changes: 1 addition & 1 deletion sdk/synapse/Azure.Analytics.Synapse.ManagedPrivateEndpoints/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Run `dotnet msbuild /t:GenerateCode` to generate code.
> see https://aka.ms/autorest

```yaml
repo: https://github.com/Azure/azure-rest-api-specs/blob/eea7c0141c0b7ad9f66f8ba06560b549c6b3b014
repo: https://github.com/Azure/azure-rest-api-specs/blob/ca0ac888f84b97feaef05fad6632f41ef1a399e6
```

``` yaml
Expand Down
2 changes: 1 addition & 1 deletion ...Analytics.Synapse.ManagedPrivateEndpoints/tests/ManagedPrivateEndpointsClientLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ public ManagedPrivateEndpointsClientLiveTests(bool isAsync) : base(isAsync)
{
}

[Test]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
[Test]
public async Task TestManagedPrivateEndpoints()
{
// Create a managed private endpoint
Expand Down
1 change: 0 additions & 1 deletion sdk/synapse/Azure.Analytics.Synapse.ManagedPrivateEndpoints/tests/samples/SampleSnippets.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ namespace Azure.Analytics.Synapse.ManagedPrivateEndpoints.Samples
public partial class Snippets : SampleFixture
{
[Test]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
public void TestManagedPrivateEndpoint()
{
#region Snippet:CreateClient
Expand Down
8 changes: 4 additions & 4 deletions ...synapse/Azure.Analytics.Synapse.Monitoring/src/Generated/Models/SparkJob.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Monitoring/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Run `dotnet msbuild /t:GenerateCode` to generate code.
> see https://aka.ms/autorest

```yaml
repo: https://github.com/Azure/azure-rest-api-specs/tree/eea7c0141c0b7ad9f66f8ba06560b549c6b3b014
repo: https://github.com/Azure/azure-rest-api-specs/tree/ca0ac888f84b97feaef05fad6632f41ef1a399e6
```

``` yaml
Expand Down
1 change: 0 additions & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Monitoring/tests/MonitoringClientLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ public MonitoringClientLiveTests(bool isAsync) : base(isAsync)
}

[Test]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
public async Task TestListSparkApplications()
{
SparkJobListViewResponse sparkJobList = await MonitoringClient.GetSparkJobListAsync();
Expand Down
1 change: 0 additions & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Monitoring/tests/samples/Sample1_PipelineMonitoring.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ namespace Azure.Analytics.Synapse.Samples
/// </summary>
public partial class PipelineMonitoring
{
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
[Test]
public void MonitorPipelineRuns()
{
Expand Down
1 change: 0 additions & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Monitoring/tests/samples/SampleSnippets.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ namespace Azure.Analytics.Synapse.Monitoring.Samples
public partial class Snippets : SampleFixture
{
[Test]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
public void MonitoringSample()
{
#region Snippet:CreateMonitoringClient
Expand Down
4 changes: 2 additions & 2 deletions ...ynapse/Azure.Analytics.Synapse.Spark/src/Generated/Models/SparkScheduler.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...ynapse/Azure.Analytics.Synapse.Spark/src/Generated/Models/SparkStatement.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion .../Azure.Analytics.Synapse.Spark/src/Generated/Models/SparkStatementOutput.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Spark/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Run `dotnet build /t:GenerateCode` to generate code.
> see https://aka.ms/autorest

```yaml
repo: https://github.com/Azure/azure-rest-api-specs/blob/eea7c0141c0b7ad9f66f8ba06560b549c6b3b014
repo: https://github.com/Azure/azure-rest-api-specs/blob/ca0ac888f84b97feaef05fad6632f41ef1a399e6
```

``` yaml
Expand Down
1 change: 0 additions & 1 deletion sdk/synapse/Azure.Analytics.Synapse.Spark/tests/samples/Sample2_ExecuteSparkStatement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ namespace Azure.Analytics.Synapse.Samples
public partial class ExecuteSparkStatement
{
[Test]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/17455")]
public void ExecuteSparkStatementSync()
{
// Environment variable with the Synapse workspace endpoint.
Expand Down