Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase TimeoutInMinutes for FR #17709

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Increase TimeoutInMinutes for FR #17709

merged 1 commit into from
Dec 28, 2020

Conversation

maririos
Copy link
Member

With the addition of the AAD tests for every endpoint, the FR tests are taking an average of 50min (before 40min) and sometimes, if the server is busy, it can take more than 60min.
Our pipelines have a default of 60min per run, so the build fails.

Fixes: #17708

@maririos
Copy link
Member Author

/azp run net - formrecognizer - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AlexGhiondea
Copy link
Contributor

@maririos are the tests running in parallel?

@maririos
Copy link
Member Author

@maririos are the tests running in parallel?

The default for the repo is BuildInParallel: true.

As for running on multiple machines, there is the parameter MaxParallel the default is 0. I see other libraries using it, but I will like to wait on @benbp to be back from vacations before modifying this value for FR as this can impact test resources in general.

@maririos maririos merged commit 1aabcea into master Dec 28, 2020
@maririos maririos deleted the timeout branch December 28, 2020 21:35
@benbp
Copy link
Member

benbp commented Jan 4, 2021

@maririos MaxParallel == 0 means no parallel limit. Multi-machine jobs will request available machines all at once. If we see FR using up too much quota, we could add a parallel limit, but we are starting to transition over to the 1es pools which have burst capacity, so I wouldn't worry about it unless it becomes a problem.

@maririos
Copy link
Member Author

maririos commented Jan 4, 2021

Thanks for the information @benbp . Do you have a rough ETA of when the transition will happen? just for me to keep in mind
It looks like for now, this PR should be enough

@benbp
Copy link
Member

benbp commented Jan 5, 2021

@maririos actually I believe we're switched over fully for .net now as of yesterday. Double check with @mitchdenny though for more details on the burst capacity.

annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR tests are too close to build timeout
3 participants