Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify API status check changes #18176

Merged
2 commits merged into from
Feb 1, 2021
Merged

Verify API status check changes #18176

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
893a9a3
Verify API status check changes
praveenkuttappan Jan 26, 2021
dce680e
Update regex match pattern
praveenkuttappan Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eng/pipelines/templates/jobs/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ jobs:
displayName: "Tag scheduled builds"
condition: and(eq(variables['Build.SourceBranchName'],'master'),eq(variables['Build.Reason'],'Schedule'))
- template: /eng/common/pipelines/templates/steps/daily-dev-build-variable.yml
parameters:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
- pwsh: |
$skipDevBuildNumber = "false"
# For .NET builds the only case we want to not have dev build numbers on our packages is when it is manually queued and
Expand Down Expand Up @@ -89,7 +91,7 @@ jobs:
artifactName: packages
path: $(Build.ArtifactStagingDirectory)

- template: /eng/pipelines/templates/steps/create-apireview.yml
- template: /eng/common/pipelines/templates/steps/create-apireview.yml
parameters:
Artifacts: ${{parameters.Artifacts}}

Expand Down
19 changes: 0 additions & 19 deletions eng/pipelines/templates/steps/create-apireview.yml
View file
Open in desktop

This file was deleted.

104 changes: 0 additions & 104 deletions eng/scripts/Create-APIReview.ps1
View file
Open in desktop

This file was deleted.

17 changes: 13 additions & 4 deletions eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,15 @@ function Get-dotnet-PackageInfoFromRepo ($pkgPath, $serviceDirectory, $pkgName)
$projectData = New-Object -TypeName XML
$projectData.load($projectPath)
$pkgVersion = Select-XML -Xml $projectData -XPath '/Project/PropertyGroup/Version'
return [PackageProps]::new($pkgName, $pkgVersion, $pkgPath, $serviceDirectory)
$sdkType = "client"
if ($pkgName -match ".ResourceManager." -or $pkgName -match ".Management.")
praveenkuttappan marked this conversation as resolved.
Show resolved Hide resolved
{
$sdkType = "mgmt"
}
$pkgProp = [PackageProps]::new($pkgName, $pkgVersion, $pkgPath, $serviceDirectory)
$pkgProp.SdkType = $sdkType
$pkgProp.IsNewSdk = $pkgName.StartsWith("Azure")
return $pkgProp
}
else
{
Expand Down Expand Up @@ -202,13 +210,14 @@ function Update-dotnet-CIConfig($pkgs, $ciRepo, $locationInDocRepo, $monikerId=$
}

# function is used to auto generate API View
function Find-dotnet-Artifacts-For-Apireview($artifactDir, $packageName = "")
function Find-dotnet-Artifacts-For-Apireview($artifactDir, $packageName)
{
# Find all nupkg files in given artifact directory
$pkg = Get-dotnet-Package-Artifacts $artifactDir
$PackageArtifactPath = Join-Path $artifactDir $packageName
$pkg = Get-dotnet-Package-Artifacts $PackageArtifactPath
if (!$pkg)
{
Write-Host "Package is not available in artifact path $($artifactDir)"
Write-Host "Package is not available in artifact path $($PackageArtifactPath)"
return $null
}
$packages = @{ $pkg.Name = $pkg.FullName }
Expand Down