Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for create, update, and delete for custom role definitions #18227

Merged
merged 14 commits into from
Jan 29, 2021
8 changes: 7 additions & 1 deletion eng/common/TestResources/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Connect-AzAccount -Subscription 'YOUR SUBSCRIPTION ID'
eng\common\TestResources\New-TestResources.ps1 -ServiceDirectory 'search'
```

The `OutFile` switch would be set if you are running this for a .NET project on Windows. This will save test environment settings
The `OutFile` switch should be set if you are running this for a .NET project on Windows. This will save test environment settings
christothes marked this conversation as resolved.
Show resolved Hide resolved
into a test-resources.json.env file next to test-resources.json. The file is protected via DPAPI.
The environment file would be scoped to the current repository directory and avoids the need to
set environment variables or restart your IDE to recognize them.
Expand Down Expand Up @@ -89,6 +89,12 @@ Remove-AzADServicePrincipal -ApplicationId $sp.ApplicationId -Force

If you persisted environment variables, you should also remove those as well.

Some scripts accept the `AdditionalParameters` parameter to control additional resource configuration options. For example:

```powershell
.\eng\common\TestResources\New-TestResources.ps1 keyvault -AdditionalParameters @{enableHsm = $true}
```

## In CI

Test pipelines should include deploy-test-resources.yml and
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## 4.0.0-beta.4 (Unreleased)

### Added

- Support in `KeyVaultAccessControlClient` to create, update, and delete custom role definitions.

## 4.0.0-beta.3 (2020-11-12)

Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using System;
using Azure.Core;

namespace Azure.Security.KeyVault.Administration.Models
{
[CodeGenModel("DataAction")]
public readonly partial struct KeyVaultDataAction : IEquatable<KeyVaultDataAction>
{ }
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading