[DRAFT]Guli/dev/dns resolvers #18719
Conversation
The focus of these changes is to virtualize read-only properties that cannot be set as part of the constructor to enable mocking them during testing.
* EG API updates * webjob tests * Use optional serializer param in GetData<T> methods; revert culture in SAS
Co-authored-by: Victor XField <vxfield@outlook.com>
Azure#18227) * Implement create, update, get, and delete for Role Definitions
Changed the type for `IEnumerable` to `IList` as this is a property in an input-only object. Followed what other libraries like Search and KV do.
* Updates for GA version - <AzureApiTag>Capacity_2020-10-01-preview;Capacity_2020-10-25;</AzureApiTag> * Updating release notes. * Updating version to -Preview - 1.15.0-preview * Updated Package release notes. * Removing -Preview from changelog.md to fix CI build error. * Adding -Preview to Package version. * Updating recorded Tests. * Updating Tests. * Uprating the version to - <Version>1.15.0-preview</Version> in csproj file. * Updating Tests. * Updating commit ID. * Removing model files not nrequired.
To ensure we always include the global variables in all our pipeline jobs and stages we should import the variables at the highest pipeline level to ensure we don't miss setting these variables in any jobs.
* Enforce API approval status for GA and include SDK type in package properties * Fix per review comment * Fixes as per review comments to avoid changing constructor signature * Fixes as per review comments to handle track 1 packages * Fix yaml format error Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
In this PR: - Ability to provide a handler to capture queue messages that are in invalid format. Bonus: - Ability to get parent queue service (like we did in Azure#16437 ) Pending dependency: Azure#18170
* language and locale as extensible enums
…8281) * upgrading msal dependency * update changelog * updating test recordings
The sample tests weren't intended to be run in the CI, but were instead useful to demonstrate how you might perform the different methods of authentication. That's actually done in the README now, so i'm just going to remove it since I can't make the build happy with keeping them around.
Increment package version after release of Azure.Identity
* tweaks to New-TestResources readme
The focus of these changes is to fix a typo in label application for the Digital Twins service. The ownership of Service Bus has also been tweaked to reflect a change in areas of responsibility.
Co-authored-by: Shivangi Reja <shreja@microsoft.com>
Azure#18290) * Update the readme with more information about thread safety and other concepts. * Update sdk/keyvault/Azure.Security.KeyVault.Administration/README.md Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> * Update sdk/keyvault/Azure.Security.KeyVault.Administration/README.md Co-authored-by: Heath Stewart <heaths@outlook.com> * Address PR feedback. Co-authored-by: Mariana Rios Flores <mariari@microsoft.com> Co-authored-by: Heath Stewart <heaths@outlook.com>
guandali
requested review from
ankitarorabit,
annelo-msft,
azabbasi,
barustum,
bikamani,
DominikMe,
drwill-ms,
heaths,
jamdavi,
jfggdl,
JoshLove-msft,
jsquire,
kayousef-zz,
kinelski,
Kishp01,
KrzysztofCwalina,
maririos,
pakrym,
RezaJooyandeh,
schaabs,
serkantkaraca,
tg-msft,
timtay-microsoft,
toddysm,
vinagesh,
yugangw-msft and
a team
as code owners
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
new servicelabel and/or contact assigned reviewer.Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.