Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Support 2021-02-01 and upgrade to 20.0.0 #19817

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

blueww
Copy link
Member

@blueww blueww commented Mar 25, 2021

All SDK Contribution checklist:

swagger PR merged: Azure/azure-rest-api-specs#13550

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Mar 25, 2021
@YalinLi0312
Copy link
Member

Hi @blueww , could you fix the errors in ci checks?

@blueww
Copy link
Member Author

blueww commented Mar 26, 2021

The error looks like a network error on download nuget package in build.
Will rerun the CI

/Users/runner/hostedtoolcache/dotnet/sdk/5.0.200/NuGet.targets(131,5): error : Failed to download package 'Microsoft.AspNetCore.Authorization.Policy.2.1.0' from 'https://api.nuget.org/v3-flatcontainer/microsoft.aspnetcore.authorization.policy/2.1.0/microsoft.aspnetcore.authorization.policy.2.1.0.nupkg'. [/Users/runner/work/1/s/eng/service.proj]
/Users/runner/hostedtoolcache/dotnet/sdk/5.0.200/NuGet.targets(131,5): error : The HTTP request to 'GET https://api.nuget.org/v3-flatcontainer/microsoft.aspnetcore.authorization.policy/2.1.0/microsoft.aspnetcore.authorization.policy.2.1.0.nupkg' has timed out after 100000ms. [/Users/runner/work/1/s/eng/service.proj]
/Users/runner/hostedtoolcache/dotnet/sdk/5.0.200/NuGet.targets(131,5): error : The feed 'nuget.org [https://api.nuget.org/v3/index.json]' lists package 'Microsoft.AspNetCore.Authorization.Policy.2.1.0' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again. [/Users/runner/work/1/s/eng/service.proj]
/Users/runner/hostedtoolcache/dotnet/sdk/5.0.200/NuGet.targets(131,5): error : Unable to find package 'Microsoft.AspNetCore.Authorization.Policy.2.1.0'. [/Users/runner/work/1/s/eng/service.proj]

@blueww
Copy link
Member Author

blueww commented Mar 26, 2021

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@blueww
Copy link
Member Author

blueww commented Mar 26, 2021

@YalinLi0312

The only CI failure is not valid:

The failure is on verify generated code, error is "Discrepancy detected between generated code in PR and reference generation." But I have not change the code after generate it.

Since autorest issue Azure/autorest.csharp#885, (.net SDK code should skip validate optional properties if it's null), generate .net SRP SDK code must use --use:@microsoft.azure/autorest.csharp@2.3.90 now, and I have added it into generate.ps1.

But the code generated by CI will always check the optional properties no matter it's null or not, so the CI generated code seems not right. It seems CI don't generate SDK code use the correct autorest version, so it might not use generate.ps1 correctly.

Besides that, the failure also occur in before PR #18844 which is already merged.
Please help to review and merged this PR if no other comments.
And please help to fix the CI failure by using correct autorest version, to avoid it fail again in the future PR.

@allenjzhang allenjzhang merged commit d745d35 into Azure:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants