-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Support 2021-02-01 and upgrade to 20.0.0 #19817
Conversation
Hi @blueww , could you fix the errors in ci checks? |
The error looks like a network error on download nuget package in build.
|
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
The only CI failure is not valid: The failure is on verify generated code, error is "Discrepancy detected between generated code in PR and reference generation." But I have not change the code after generate it. Since autorest issue Azure/autorest.csharp#885, (.net SDK code should skip validate optional properties if it's null), generate .net SRP SDK code must use But the code generated by CI will always check the optional properties no matter it's null or not, so the CI generated code seems not right. It seems CI don't generate SDK code use the correct autorest version, so it might not use generate.ps1 correctly. Besides that, the failure also occur in before PR #18844 which is already merged. |
All SDK Contribution checklist:
swagger PR merged: Azure/azure-rest-api-specs#13550
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
new service
label and/or contact assigned reviewer.Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.