[Storage] Updated tests to support multiple SAS versions #20544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmcc-msft
requested review from
amishra-dev,
amnguye,
kasobol-msft and
tg-msft
as code owners
ghost
added
the
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
seanmcc-msft
commented
Apr 20, 2021
| @@ -532,7 +532,11 @@ private void EnsureState() | |||
| Resource = Constants.Sas.Resource.BlobVersion; | |||
| } | |||
| } | |||
| Version = SasQueryParameters.DefaultSasVersion; | |||
|
|
|||
| if (string.IsNullOrEmpty(Version)) | |||
There was a problem hiding this comment.
This is 1 of 2 logic changes I made in customer-facing code. This if check is present in Data Lake, File Shares, and Queues, but was not present in blob for some reason.
| new DataLakeSasBuilder(permissions, expiresOn) | ||
| { | ||
| FileSystemName = Name, | ||
| Version = StorageVersionExtensions.ToVersionString(ClientConfiguration.Version) |
There was a problem hiding this comment.
This is the other customer-facing change. Now, the SAS version will match the x-ms-version of the client that generated it. This is necessary to pass the correct sas version into our tests.
There was a problem hiding this comment.
I also made this change in other client's GenerateSasUri() methods.
seanmcc-msft
commented
Apr 20, 2021
| @@ -77,7 +77,7 @@ public class DataLakePathClient | |||
| /// <summary> | |||
| /// <see cref="DataLakeClientConfiguration"/>. | |||
| /// </summary> | |||
| private readonly DataLakeClientConfiguration _clientConfiguration; | |||
| internal readonly DataLakeClientConfiguration _clientConfiguration; | |||
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.