-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stable API Version for point-in-time restore. #21768
Merged
YalinLi0312
merged 7 commits into
Azure:main
from
amisi01:users/amisi/addingnewtestsforstableversion
Jun 18, 2021
Merged
Add Stable API Version for point-in-time restore. #21768
YalinLi0312
merged 7 commits into
Azure:main
from
amisi01:users/amisi/addingnewtestsforstableversion
Jun 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisi01
requested review from
allenjzhang,
m-nash,
markcowl,
nisha-bhatia and
YalinLi0312
as code owners
June 10, 2021 06:41
Hi @amisi01, please fix the failing CI. Thanks! |
amisi01
force-pushed
the
users/amisi/addingnewtestsforstableversion
branch
2 times, most recently
from
June 16, 2021 08:53
fca485d
to
d5bbfda
Compare
amisi01
force-pushed
the
users/amisi/addingnewtestsforstableversion
branch
2 times, most recently
from
June 16, 2021 22:49
15af6a3
to
b1cc71c
Compare
amisi01
force-pushed
the
users/amisi/addingnewtestsforstableversion
branch
from
June 16, 2021 23:39
b1cc71c
to
ce53089
Compare
Hi @YalinLi0312 , I have fixed the CI. Could you please take a look. Thanks |
Merged swagger PR link - Azure/azure-rest-api-specs#14627 |
@amisi01 Please also update the versions in AssemblyInfo.cs. |
YalinLi0312
approved these changes
Jun 18, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Jan 6, 2023
Add scan folder and spark config support in Sparkjob activity (Azure#21768) * add scan folder and spark config support * fix typo * update description * add custom word
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.