Produce ActivitySource events #23192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itySource-events # Conflicts: # sdk/core/Azure.Core.TestFramework/src/Azure.Core.TestFramework.csproj
…NET5 instead of forcing it on everyone by lifting the reference version.
…itySource-events # Conflicts: # sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/EventGridPublisherClient.cs # sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs
# Conflicts: # sdk/core/Azure.Core/src/Pipeline/Internal/RequestActivityPolicy.cs
ghost
added
pakrym
requested review from
orenmichaely,
petrsvihlik,
rajkumar-rangaraj,
rasidhan,
reyang,
schaabs,
TimothyMothra,
timtay-microsoft,
tyclintw,
vicancy,
vinagesh,
vishweshbankwar,
weshaggard,
yeskarthik and
a team
as code owners
heaths
approved these changes
Sep 17, 2021
sdk/core/Azure.Core/src/Pipeline/Internal/RequestActivityPolicy.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 20, 2021
It's the least I can do while tagging the entire world on the PR. |
…ySource-events # Conflicts: # eng/Directory.Build.Common.targets # sdk/communication/Azure.Communication.CallingServer/src/Azure.Communication.CallingServer.csproj # sdk/communication/Azure.Communication.Chat/src/Azure.Communication.Chat.csproj # sdk/communication/Azure.Communication.Identity/src/Azure.Communication.Identity.csproj # sdk/communication/Azure.Communication.NetworkTraversal/src/Azure.Communication.NetworkTraversal.csproj # sdk/communication/Azure.Communication.PhoneNumbers/src/Azure.Communication.PhoneNumbers.csproj # sdk/communication/Azure.Communication.Sms/src/Azure.Communication.Sms.csproj # sdk/core/Azure.Core.Experimental/tests/Azure.Core.Experimental.Tests.csproj # sdk/storage/Azure.Storage.Blobs.Batch/src/Azure.Storage.Blobs.Batch.csproj # sdk/storage/Azure.Storage.Blobs.ChangeFeed/src/Azure.Storage.Blobs.ChangeFeed.csproj # sdk/storage/Azure.Storage.Common/tests/Azure.Storage.Common.Tests.csproj
lmolkova
approved these changes
Sep 27, 2021
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET 5 introduced a new way to create distributed tracing activities - ActivitySource. We've been using an older system, DiagnosticSource, to expose distributing tracing data to ApplicationInsights. OpenTelemetry uses ActivitySource to collect its distributing tracing event.
This PR adds ActivitySource support to Azure SDKs. ActivitySource support means that we also support OpenTelemetry. We put ActivitySource support behind an experimental AppContext flag. Many specs that describe the kinds and shapes of OpenTelemetry telemetry spans are still experimental. We don't want customers taking an accidental dependency on names/attributes/parent-child relationships etc.
ActivitySource support is abstracted behind ClientDiagnostics/DiagnosticScope infrastructure the same way as DiagnosticSource was before. Clients authors don't have to make changes to the library code; the entire feature is handled in the shared code.
A bit more details in the upcoming blog post https://github.com/Azure/azure-sdk-blog/pull/168