Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage STG 79 #23923

Merged
merged 24 commits into from
Sep 16, 2021
Merged

Storage STG 79 #23923

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f5713da
Added 2020-12-06 service version
seanmcc-msft Aug 2, 2021
d76b020
Continued adding new service version
seanmcc-msft Aug 2, 2021
50f8b2b
Updated test recordings
seanmcc-msft Aug 2, 2021
9a574d3
Export-API.ps1
seanmcc-msft Aug 2, 2021
c26fd79
Added support for Encryption Scopes for Blob Sync Copy (#23118)
seanmcc-msft Aug 10, 2021
b1d5bba
HNS Encryption Scopes (#23130)
seanmcc-msft Aug 10, 2021
a57c34a
Encryption Scope SAS (#23145)
seanmcc-msft Aug 24, 2021
6a1ef5e
Merge branch 'main' into feature/storage/stg79base
seanmcc-msft Aug 24, 2021
ebfc04f
Merge branch 'main' into feature/storage/stg79base
seanmcc-msft Aug 26, 2021
89314b1
Added Permanent Delete SAS (#23693)
seanmcc-msft Sep 7, 2021
4b527c5
Merge branch 'main' into feature/storage/stg79base
seanmcc-msft Sep 8, 2021
5179c7d
Fixed CI
seanmcc-msft Sep 8, 2021
35a46a6
Merge branch 'main' into feature/storage/stg79base
seanmcc-msft Sep 9, 2021
6881c82
STG 79 changelogs (#23920)
seanmcc-msft Sep 9, 2021
40021ee
CI + Live tests
seanmcc-msft Sep 9, 2021
4536a7f
Revert "CI + Live tests"
seanmcc-msft Sep 9, 2021
118b4aa
Hopefully fixed live tests
seanmcc-msft Sep 10, 2021
2d7c0d3
Export API
seanmcc-msft Sep 10, 2021
f8a761f
Fixing live tests
seanmcc-msft Sep 10, 2021
614b2b9
live tests
seanmcc-msft Sep 13, 2021
088b6df
Revert "HNS Encryption Scopes (#23130)"
seanmcc-msft Sep 15, 2021
1240be8
Removed DataLake Encryption SAS
seanmcc-msft Sep 15, 2021
b766c82
Removed unnecessary TODOs
seanmcc-msft Sep 15, 2021
2c8d984
Updated Data Lake changelog
seanmcc-msft Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/storage/Azure.Storage.Files.DataLake/tests/DirectoryClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3464,7 +3464,9 @@ public async Task GetPropertiesAsync()
}

[RecordedTest]
[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_10_02)]
// TODO https://github.com/Azure/azure-sdk-for-net/issues/23369
// Change min service version to 2020-10-02
[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_12_06)]
public async Task GetPropertiesAsync_EncryptionScope()
{
// Arrange
Expand Down
12 changes: 9 additions & 3 deletions sdk/storage/Azure.Storage.Files.DataLake/tests/FileSystemClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,9 @@ public async Task CreateAsync()
}

[RecordedTest]
[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_10_02)]
// TODO https://github.com/Azure/azure-sdk-for-net/issues/23369
// Change min service version to 2020-10-02
[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_12_06)]
public async Task CreateAsync_EncryptionScopeOptions()
{
// Arrange
Expand Down Expand Up @@ -471,7 +473,9 @@ public async Task CreateIfNotExistAsync_Exists()
}

[RecordedTest]
[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_10_02)]
// TODO https://github.com/Azure/azure-sdk-for-net/issues/23369
// Change min service version to 2020-10-02
[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_12_06)]
public async Task CreateIfNotExists_EncryptionScopeOptions()
{
// Arrange
Expand Down Expand Up @@ -772,7 +776,9 @@ public async Task GetPathsAsync()
}

[RecordedTest]
[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_10_02)]
// TODO https://github.com/Azure/azure-sdk-for-net/issues/23369
// Change min service version to 2020-10-02
[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_12_06)]
public async Task GetPathsAsync_EncryptionScopeOptions()
{
// Arrange
Expand Down
7 changes: 6 additions & 1 deletion sdk/storage/Azure.Storage.Files.DataLake/tests/ServiceClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,9 @@ public async Task GetFileSystemsAsync()
}

[RecordedTest]
[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_10_02)]
// TODO https://github.com/Azure/azure-sdk-for-net/issues/23369
// Change min service version to 2020-10-02
[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_12_06)]
public async Task GetFileSystemsAsync_EncryptionScope()
{
// Arrange
Expand Down Expand Up @@ -377,6 +379,9 @@ public async Task CreateFileSystemAsync()
}

[RecordedTest]
// TODO https://github.com/Azure/azure-sdk-for-net/issues/23369
// Change min service version to 2020-10-02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the record. If this is a possibility then we're dealing with breaking change. Otherwise these comments about lowering service version don't make much sense and should be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will remove these comments pending the result of the email chain. I suspect the min service version for all the STG 79 features is 2020-12-06.

[ServiceVersion(Min = DataLakeClientOptions.ServiceVersion.V2020_12_06)]
public async Task CreateFileSystemAsync_EncryptionScopeOptions()
{
var name = GetNewFileSystemName();
Expand Down