Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Schema registry] Stream fix / typo #39270

Merged
merged 2 commits into from
Oct 16, 2023
Merged

[Schema registry] Stream fix / typo #39270

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a5570d
fixes
m-redding Oct 13, 2023
035a8c1
Update sdk/schemaregistry/Azure.Data.SchemaRegistry/samples/Sample02_…
m-redding Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/schemaregistry/Azure.Data.SchemaRegistry/samples/Sample02_Serialization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ internal class SampleJsonValidator : SchemaValidator
}
```

## Serialize and deserialize JSON data using the Event H
## Serialize and deserialize JSON data using the Event Hub `EventData` model
m-redding marked this conversation as resolved.
Show resolved Hide resolved

In order to serialize an `EventData` instance with JSON information, you can do the following:

Expand Down
2 changes: 1 addition & 1 deletion sdk/schemaregistry/Azure.Data.SchemaRegistry/src/Serialization/SchemaRegistrySerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ private async ValueTask<object> DeserializeInternalAsync(
try
{
// Attempt to deserialize
var dataStream = data.ToStream();
using var dataStream = data.ToStream();
m-redding marked this conversation as resolved.
Show resolved Hide resolved
if (async)
{
objectToReturn = await deserializer.DeserializeAsync(dataStream, dataType, cancellationToken: cancellationToken).ConfigureAwait(false);
Expand Down