Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move lineCounter app to azure-sdk repo #9271

Merged
merged 6 commits into from
Jan 3, 2020
Merged

Move lineCounter app to azure-sdk repo #9271

merged 6 commits into from
Jan 3, 2020

Conversation

JoshLove-msft
Copy link
Member

Changes from https://github.com/pakrym/LineCounter

  • Use EventHubs Preview 6
  • Use App Insights instead of Zipkin
  • append .html to end of view file path to avoid server error involving accessing path with extensions like .cs

@JoshLove-msft JoshLove-msft marked this pull request as ready for review December 30, 2019 20:47
pakrym
pakrym reviewed Jan 2, 2020
View reviewed changes
samples/linecounter/LICENSE Outdated Show resolved Hide resolved
@JoshLove-msft
Copy link
Member Author

FYI @jongio @kaerm

@JoshLove-msft JoshLove-msft merged commit a179e34 into Azure:master Jan 3, 2020
@JoshLove-msft JoshLove-msft deleted the line-counter branch January 3, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym pakrym pakrym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshLove-msft @pakrym