Generated from 59261cd2c340a084e21f6b02bdaad18f1494647b

[Microsoft.Security] avoiding URL encoding for resource ID parameters
Azure · Jun 10, 2020 · c4441a7 · c4441a7
1 parent 745b5c2
commit c4441a7
Show file tree

Hide file tree

Showing 9 changed files with 35 additions and 40 deletions.
diff --git a/sdk/security/azure-mgmt-security/README.md b/sdk/security/azure-mgmt-security/README.md
@@ -1,29 +1,21 @@
-## Microsoft Azure SDK for Python
+# Microsoft Azure SDK for Python
 
 This is the Microsoft Azure Security Center Management Client Library.
+This package has been tested with Python 2.7, 3.5, 3.6, 3.7 and 3.8.
+For a more complete view of Azure libraries, see the [Github repo](https://github.com/Azure/azure-sdk-for-python/)
 
-Azure Resource Manager (ARM) is the next generation of management APIs
-that replace the old Azure Service Management (ASM).
 
-This package has been tested with Python 2.7, 3.5, 3.6 and 3.7.
+# Usage
 
-For the older Azure Service Management (ASM) libraries, see
-[azure-servicemanagement-legacy](https://pypi.python.org/pypi/azure-servicemanagement-legacy)
-library.
+For code examples, see [Security Center Management](https://docs.microsoft.com/python/api/overview/azure/)
+on docs.microsoft.com.
 
-For a more complete set of Azure libraries, see the
-[azure](https://pypi.python.org/pypi/azure) bundle package.
 
-## Usage
+# Provide Feedback
 
-For code examples, see [Security Center
-Management](https://docs.microsoft.com/python/api/overview/azure/) on
-docs.microsoft.com.
-
-## Provide Feedback
-
-If you encounter any bugs or have suggestions, please file an issue in
-the [Issues](https://github.com/Azure/azure-sdk-for-python/issues)
+If you encounter any bugs or have suggestions, please file an issue in the
+[Issues](https://github.com/Azure/azure-sdk-for-python/issues)
 section of the project.
 
-![image](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-python%2Fazure-mgmt-security%2FREADME.png)
+
+![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-python%2Fazure-mgmt-security%2FREADME.png)
diff --git a/...re-mgmt-security/azure/mgmt/security/operations/_advanced_threat_protection_operations.py b/...re-mgmt-security/azure/mgmt/security/operations/_advanced_threat_protection_operations.py
@@ -62,7 +62,7 @@ def get(
         # Construct URL
         url = self.get.metadata['url']
         path_format_arguments = {
-            'resourceId': self._serialize.url("resource_id", resource_id, 'str'),
+            'resourceId': self._serialize.url("resource_id", resource_id, 'str', skip_quote=True),
             'settingName': self._serialize.url("self.setting_name", self.setting_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -127,7 +127,7 @@ def create(
         # Construct URL
         url = self.create.metadata['url']
         path_format_arguments = {
-            'resourceId': self._serialize.url("resource_id", resource_id, 'str'),
+            'resourceId': self._serialize.url("resource_id", resource_id, 'str', skip_quote=True),
             'settingName': self._serialize.url("self.setting_name", self.setting_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)

diff --git a/sdk/security/azure-mgmt-security/azure/mgmt/security/operations/_assessments_operations.py b/sdk/security/azure-mgmt-security/azure/mgmt/security/operations/_assessments_operations.py
@@ -62,7 +62,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list.metadata['url']
                 path_format_arguments = {
-                    'scope': self._serialize.url("scope", scope, 'str')
+                    'scope': self._serialize.url("scope", scope, 'str', skip_quote=True)
                 }
                 url = self._client.format_url(url, **path_format_arguments)
 
@@ -134,7 +134,7 @@ def get(
         # Construct URL
         url = self.get.metadata['url']
         path_format_arguments = {
-            'resourceId': self._serialize.url("resource_id", resource_id, 'str'),
+            'resourceId': self._serialize.url("resource_id", resource_id, 'str', skip_quote=True),
             'assessmentName': self._serialize.url("assessment_name", assessment_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -202,7 +202,7 @@ def create_or_update(
         # Construct URL
         url = self.create_or_update.metadata['url']
         path_format_arguments = {
-            'resourceId': self._serialize.url("resource_id", resource_id, 'str'),
+            'resourceId': self._serialize.url("resource_id", resource_id, 'str', skip_quote=True),
             'assessmentName': self._serialize.url("assessment_name", assessment_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -270,7 +270,7 @@ def delete(
         # Construct URL
         url = self.delete.metadata['url']
         path_format_arguments = {
-            'resourceId': self._serialize.url("resource_id", resource_id, 'str'),
+            'resourceId': self._serialize.url("resource_id", resource_id, 'str', skip_quote=True),
             'assessmentName': self._serialize.url("assessment_name", assessment_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)

diff --git a/...rity/azure-mgmt-security/azure/mgmt/security/operations/_compliance_results_operations.py b/...rity/azure-mgmt-security/azure/mgmt/security/operations/_compliance_results_operations.py
@@ -62,7 +62,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list.metadata['url']
                 path_format_arguments = {
-                    'scope': self._serialize.url("scope", scope, 'str')
+                    'scope': self._serialize.url("scope", scope, 'str', skip_quote=True)
                 }
                 url = self._client.format_url(url, **path_format_arguments)
 
@@ -131,7 +131,7 @@ def get(
         # Construct URL
         url = self.get.metadata['url']
         path_format_arguments = {
-            'resourceId': self._serialize.url("resource_id", resource_id, 'str'),
+            'resourceId': self._serialize.url("resource_id", resource_id, 'str', skip_quote=True),
             'complianceResultName': self._serialize.url("compliance_result_name", compliance_result_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)

diff --git a/sdk/security/azure-mgmt-security/azure/mgmt/security/operations/_compliances_operations.py b/sdk/security/azure-mgmt-security/azure/mgmt/security/operations/_compliances_operations.py
@@ -62,7 +62,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list.metadata['url']
                 path_format_arguments = {
-                    'scope': self._serialize.url("scope", scope, 'str')
+                    'scope': self._serialize.url("scope", scope, 'str', skip_quote=True)
                 }
                 url = self._client.format_url(url, **path_format_arguments)
 
@@ -132,7 +132,7 @@ def get(
         # Construct URL
         url = self.get.metadata['url']
         path_format_arguments = {
-            'scope': self._serialize.url("scope", scope, 'str'),
+            'scope': self._serialize.url("scope", scope, 'str', skip_quote=True),
             'complianceName': self._serialize.url("compliance_name", compliance_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)

diff --git a/.../azure-mgmt-security/azure/mgmt/security/operations/_device_security_groups_operations.py b/.../azure-mgmt-security/azure/mgmt/security/operations/_device_security_groups_operations.py
@@ -61,7 +61,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list.metadata['url']
                 path_format_arguments = {
-                    'resourceId': self._serialize.url("resource_id", resource_id, 'str')
+                    'resourceId': self._serialize.url("resource_id", resource_id, 'str', skip_quote=True)
                 }
                 url = self._client.format_url(url, **path_format_arguments)
 
@@ -132,7 +132,7 @@ def get(
         # Construct URL
         url = self.get.metadata['url']
         path_format_arguments = {
-            'resourceId': self._serialize.url("resource_id", resource_id, 'str'),
+            'resourceId': self._serialize.url("resource_id", resource_id, 'str', skip_quote=True),
             'deviceSecurityGroupName': self._serialize.url("device_security_group_name", device_security_group_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -198,7 +198,7 @@ def create_or_update(
         # Construct URL
         url = self.create_or_update.metadata['url']
         path_format_arguments = {
-            'resourceId': self._serialize.url("resource_id", resource_id, 'str'),
+            'resourceId': self._serialize.url("resource_id", resource_id, 'str', skip_quote=True),
             'deviceSecurityGroupName': self._serialize.url("device_security_group_name", device_security_group_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -265,7 +265,7 @@ def delete(
         # Construct URL
         url = self.delete.metadata['url']
         path_format_arguments = {
-            'resourceId': self._serialize.url("resource_id", resource_id, 'str'),
+            'resourceId': self._serialize.url("resource_id", resource_id, 'str', skip_quote=True),
             'deviceSecurityGroupName': self._serialize.url("device_security_group_name", device_security_group_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)

diff --git a/...mt-security/azure/mgmt/security/operations/_information_protection_policies_operations.py b/...mt-security/azure/mgmt/security/operations/_information_protection_policies_operations.py
@@ -63,7 +63,7 @@ def get(
         # Construct URL
         url = self.get.metadata['url']
         path_format_arguments = {
-            'scope': self._serialize.url("scope", scope, 'str'),
+            'scope': self._serialize.url("scope", scope, 'str', skip_quote=True),
             'informationProtectionPolicyName': self._serialize.url("information_protection_policy_name", information_protection_policy_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -133,7 +133,7 @@ def create_or_update(
         # Construct URL
         url = self.create_or_update.metadata['url']
         path_format_arguments = {
-            'scope': self._serialize.url("scope", scope, 'str'),
+            'scope': self._serialize.url("scope", scope, 'str', skip_quote=True),
             'informationProtectionPolicyName': self._serialize.url("information_protection_policy_name", information_protection_policy_name, 'str')
         }
         url = self._client.format_url(url, **path_format_arguments)
@@ -201,7 +201,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list.metadata['url']
                 path_format_arguments = {
-                    'scope': self._serialize.url("scope", scope, 'str')
+                    'scope': self._serialize.url("scope", scope, 'str', skip_quote=True)
                 }
                 url = self._client.format_url(url, **path_format_arguments)
 

diff --git a/...ecurity/azure-mgmt-security/azure/mgmt/security/operations/_sub_assessments_operations.py b/...ecurity/azure-mgmt-security/azure/mgmt/security/operations/_sub_assessments_operations.py
@@ -63,7 +63,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list_all.metadata['url']
                 path_format_arguments = {
-                    'scope': self._serialize.url("scope", scope, 'str')
+                    'scope': self._serialize.url("scope", scope, 'str', skip_quote=True)
                 }
                 url = self._client.format_url(url, **path_format_arguments)
 
@@ -137,7 +137,7 @@ def prepare_request(next_link=None):
                 # Construct URL
                 url = self.list.metadata['url']
                 path_format_arguments = {
-                    'scope': self._serialize.url("scope", scope, 'str'),
+                    'scope': self._serialize.url("scope", scope, 'str', skip_quote=True),
                     'assessmentName': self._serialize.url("assessment_name", assessment_name, 'str')
                 }
                 url = self._client.format_url(url, **path_format_arguments)
@@ -212,7 +212,7 @@ def get(
         # Construct URL
         url = self.get.metadata['url']
         path_format_arguments = {
-            'scope': self._serialize.url("scope", scope, 'str'),
+            'scope': self._serialize.url("scope", scope, 'str', skip_quote=True),
             'assessmentName': self._serialize.url("assessment_name", assessment_name, 'str'),
             'subAssessmentName': self._serialize.url("sub_assessment_name", sub_assessment_name, 'str')
         }

diff --git a/sdk/security/azure-mgmt-security/setup.py b/sdk/security/azure-mgmt-security/setup.py
@@ -36,7 +36,9 @@
     pass
 
 # Version extraction inspired from 'requests'
-with open(os.path.join(package_folder_path, 'version.py'), 'r') as fd:
+with open(os.path.join(package_folder_path, 'version.py') 
+          if os.path.exists(os.path.join(package_folder_path, 'version.py'))
+          else os.path.join(package_folder_path, '_version.py'), 'r') as fd:
     version = re.search(r'^VERSION\s*=\s*[\'"]([^\'"]*)[\'"]',
                         fd.read(), re.MULTILINE).group(1)
 
@@ -67,6 +69,7 @@
         'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
+        'Programming Language :: Python :: 3.8',
         'License :: OSI Approved :: MIT License',
     ],
     zip_safe=False,