Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better name for Search Indexer DataSource #11515

Closed
bryevdv opened this issue May 18, 2020 · 3 comments
Closed

Better name for Search Indexer DataSource #11515

bryevdv opened this issue May 18, 2020 · 3 comments
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search
Milestone

Comments

@bryevdv
Copy link
Contributor

bryevdv commented May 18, 2020

Currently to create a SearchIndexer you must first create a DataSource that desribes a connection to some external data source to be indexed (e.g. data in Azure blob storage). Nearly every UX study participant was confused by this, and thought e.g. that the DataSource object was somehow the external data source (rather than a description of if) or that blob storage clients could be passed directly to the search indexer.

Has been suggested a different name could help make the purpose of this model more evident.

  • DataSourceConnection
  • DataSourceRelation
  • DataSourceDescription

For further work, perhaps it would make sense to see if e.g. a blob storage client could just be accepted directly (this was asked for by at least one participant)

cc @xiangyan99 @heaths and this will probably need to be taken up with the team and @brjohnstmsft

@bryevdv bryevdv added Search Client This issue points to a problem in the data-plane of the library. blocking-release Blocks release labels May 18, 2020
@brjohnstmsft
Copy link
Member

FWIW I like DataSourceConnection. Adding @bleroy for his opinion.

@heaths
Copy link
Member

heaths commented May 19, 2020

I like "connection", although, that should be SearchIndexerDataSourceConnection given the naming convention we already established.

@AlexGhiondea AlexGhiondea added this to the [2020] June milestone May 21, 2020
@heaths
Copy link
Member

heaths commented May 21, 2020

I opened #11565 which includes this (similar bugs opened across other languages).

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Development

No branches or pull requests

4 participants