Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Search renames #11565

Closed
heaths opened this issue May 20, 2020 · 1 comment
Closed

More Search renames #11565

heaths opened this issue May 20, 2020 · 1 comment
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] June

Comments

@heaths
Copy link
Member

heaths commented May 20, 2020 •
edited
Loading

Based on UX studies, please make the following changes as well:

Old name New name Notes
SearchIndexerDataSource SearchIndexerDataSourceConnection
SearchField.SynonymMaps SearchField.SynonymMapNames For dynamic languages with union support, you could instead accept either a string or object and, if an object that is a SynonymMap, extract it's name. But it's not always practical to expect they will create or even get a synonym map just to pass it in, so a string name (these are managed separately) is still required to be supported.
SearchField.Analyzer SearchField.AnalyzerName
SearchField.IndexAnalyzer SearchField.IndexAnalyzerName
SearchField.SearchAnalyzer SearchField.SearchAnalyzerName
SearchableField.SynonymMaps SearchableField.SynonymMapNames Same as above
SearchableField.Analyzer SearchableField.AnalyzerName
SearchableField.IndexAnalyzer SearchableField.IndexAnalyzerName
SearchableField.SearchAnalyzer SearchableField.SearchAnalyzerName
@heaths heaths added blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search labels May 20, 2020
@heaths heaths added this to the [2020] June milestone May 20, 2020
@heaths heaths mentioned this issue May 21, 2020
Closed
This was referenced May 22, 2020
Merged
Merged
@heaths heaths mentioned this issue May 28, 2020
Closed
@xiangyan99
Copy link
Member

Fixed in #11683

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] June
Development

No branches or pull requests
2 participants
@heaths @xiangyan99