Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update samples & rename datasource methods #11683

Merged
merged 2 commits into from
May 29, 2020
Merged

update samples & rename datasource methods #11683

merged 2 commits into from
May 29, 2020

Conversation

xiangyan99
Copy link
Member

No description provided.

@xiangyan99 xiangyan99 changed the title update samples update samples & rename datasource methods May 29, 2020
@xiangyan99
Copy link
Member Author

#11693

heaths
heaths approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a rename for get_data_source_connection_names. Is that not implemented yet?

@xiangyan99
Copy link
Member Author

I don't see a rename for get_data_source_connection_names. Is that not implemented yet?

Do you mean "get_data_source_connections"?

@heaths
Copy link
Member

heaths commented May 29, 2020

It's a method to be added from #11320.

@xiangyan99
Copy link
Member Author

No. It is not in the PR. I will add it in a separate PR.

@xiangyan99 xiangyan99 merged commit 3a05ac7 into master May 29, 2020
@xiangyan99 xiangyan99 deleted the search_samples branch May 29, 2020 21:01
This was referenced May 29, 2020
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@rakshith91 rakshith91 Awaiting requested review from rakshith91

@lmazuel lmazuel Awaiting requested review from lmazuel

@mayurid mayurid Awaiting requested review from mayurid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangyan99 @heaths