Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support key export from Key Vault #13562

Closed
4 tasks done
heaths opened this issue Sep 4, 2020 · 1 comment
Closed
4 tasks done

Support key export from Key Vault #13562

heaths opened this issue Sep 4, 2020 · 1 comment
Assignees
@mccoyp
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] November

Comments

@heaths
Copy link
Member

heaths commented Sep 4, 2020 •
edited by mccoyp
Loading

NOTE: Key export is separate from key release, and is not supported by the SDK at the time of writing.

For Key Vault 7.3-preview, we need to add support to export keys. This would be a method like KeyClient.ExportKey that takes the key name, key version (both required), and a body with the KeyExportParameters model found in the link below. This only has a single required property named environment (model property: env), so we should take this as a parameter. This returns a KeyVaultKey (model KeyBundle).

This requires a number of other changes:

  • Add optional Exportable boolean property to KeyProperties.
  • Add "export" to KeyOperation enum. This will correctly impact the CreateKeyOptions class and the KeyClient.UpdateKey method.
  • Add ReleasePolicy property to CreateKeyOptions.
  • Add ReleasePolicy property to ImportKeyOptions.

See the service version 7.1 -> 7.2-preview diff 🔒 for details.
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Sep 4, 2020
@heaths heaths added this to the [2020] October milestone Sep 4, 2020
@mccoyp mccoyp removed this from the [2021] January milestone Feb 24, 2021
@mccoyp mccoyp closed this as completed Feb 24, 2021
@mccoyp mccoyp reopened this Feb 24, 2021
@mccoyp mccoyp added this to the [2021] March milestone Feb 24, 2021
@mccoyp mccoyp modified the milestones: [2021] March, [2021] April Mar 6, 2021
@mccoyp mccoyp mentioned this issue Apr 15, 2021
Merged
@mccoyp mccoyp modified the milestones: [2021] April, [2021] June Apr 16, 2021
@mccoyp mccoyp modified the milestones: [2021] June, [2021] July May 6, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue May 19, 2021
@carlocardella @chunyu3
CodeGen from PR 14302 in Azure/azure-rest-api-specs
f4a88ae 
Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (Azure#14302)

* Adds base for updating Microsoft.KubernetesConfiguration from version preview/2020-07-01-preview to version 2021-05-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add Extensions Async API and other fixes (Azure#13709)

* Add Extensions Async API and other fixes

* Re-add missed out changes

* Fix validation errors, remove UpdateExtension.json

* Update Readme.md

* Add back files removed accidentally

* Revert accidental changes & fix readme.md

* Remove SourceControlConfig from this api version

* Fix Readme.md error for go package

* Fix Go readme issues

* Fix Go readme issues - revert accidental change

* Fix Go readme issues

* Add kubernetesconfiguration GA version to this version Tag for SDK

* Fix Operations api descriptions

* Fix spelling mistakes

* Update ApiVersionParameter reference in kubernetesconfiguration

* Fix review suggestions

* Add SourceControlConfiguration resourceType to this api-version

* Updated readme files for the added SourceControlConfiguration resource type

* Fix readme files to revert to previous + additions for new api-version

* Consolidated common definitions to avoid duplication errors

* Rename definitions folder - fix Avocado error

* Consolidated common definitions reference

* Fix definitions.json

* Fix go readme

* Revert "Add Extensions Async API and other fixes (Azure#13709)" (Azure#13972)

This reverts commit b78af6ebfe1391f2c73bc39da3c20c159806b1a0.

* Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 05 01 preview (Azure#13992)

* Add Extensions Async API and other fixes

* Re-add missed out changes

* Fix validation errors, remove UpdateExtension.json

* Update Readme.md

* Add back files removed accidentally

* Revert accidental changes & fix readme.md

* Remove SourceControlConfig from this api version

* Fix Readme.md error for go package

* Fix Go readme issues

* Fix Go readme issues - revert accidental change

* Fix Go readme issues

* Add kubernetesconfiguration GA version to this version Tag for SDK

* Fix Operations api descriptions

* Fix spelling mistakes

* Update ApiVersionParameter reference in kubernetesconfiguration

* Fix review suggestions

* Add SourceControlConfiguration resourceType to this api-version

* Updated readme files for the added SourceControlConfiguration resource type

* Fix readme files to revert to previous + additions for new api-version

* Consolidated common definitions to avoid duplication errors

* Rename definitions folder - fix Avocado error

* Consolidated common definitions reference

* Fix definitions.json

* Fix go readme

* Remove extensions resource in the route of ListAsyncOperations at Cluster scope

* Remove extension parameter in the spec

* Remove extension parameter from route of ListAsycOperations

* Add Origin property to Available Operations response body

* Make Identity property nullable

* Add Get, List Extension Types (Azure#13562)

* Add Get, List Extension Types

* style check fixes

* - update spec
- rename and update example files
- fix validation errors

* fix examples

* - update readme.md
- generate example files with oav
- try to fix some new validation errors

* more validation fixes

* add ExtensionTypeVersion_List

* - update readme for SDKs
- update examples

* fix typo and linting

* rename ExtensionTypeVersions_List

* - address comments
- update list extension versions based on location

* fix list versions route

* fix tag and unused parameters in spec file

* fix autorest validatoin errors

* udpate readme

* update readme

* try to fix sdk validation warnings

* - prettier fix
- revert changes to types.json

* fix pageable missing itemName

Co-authored-by: Carlo Cardella <carloc@microsoft.com>
Co-authored-by: chunyu3 <chunyu@microsoft.com>
@mccoyp mccoyp modified the milestones: [2021] July, [2021] August Jun 24, 2021
@mccoyp mccoyp modified the milestones: [2021] August, [2021] September Aug 3, 2021
@mccoyp
Copy link
Member

mccoyp commented Oct 7, 2021

Closing since the service isn't supporting this feature for now -- we can open a new issue if this feature makes its way to the SDK.

@mccoyp mccoyp closed this as completed Oct 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mccoyp mccoyp

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] November
Development

No branches or pull requests
3 participants
@heaths @chlowell @mccoyp