Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up: Is it possible to create a VM with OS disk type different than Premium SSD? #20044

Closed
Jendker opened this issue Aug 2, 2021 · 11 comments
Assignees
Labels
Compute - VM customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@Jendker
Copy link

Jendker commented Aug 2, 2021

My previous issue #19786 was closed an I was unable to reopen it so I am opening here a new one.

Could you help me to specify the platform image parameters to use if I want to create a disk from the platform image (Ubuntu 18.04)? For now I was passing:

                'storage_profile': {
                    'image_reference': {
                        "offer": "UbuntuServer",
                        "publisher": "Canonical",
                        "sku": "18.04-LTS",
                        "urn": "Canonical:UbuntuServer:18.04-LTS:latest",
                        "urnAlias": "UbuntuLTS",
                        "version": "latest"
                    }
                },

But since 'image_reference is now osdisk I have tried passing this information in the 'creation_data':

                'creation_data': {
                    'create_option': 'from_image',
                    "id": "/Subscriptions/{}/Providers/Microsoft.Compute/Locations/westus/Publishers/Canonical/ArtifactTypes/VMImage/Offers/UbuntuServer/Skus/18.04-LTS/Versions/latest".format(self.subscription_id),
                }
            }

following this reference: https://docs.microsoft.com/en-us/rest/api/compute/disks/create-or-update#create-a-managed-disk-from-a-platform-image.
But I am getting:

Operation failed with status: 'Not Found'. Details: No HTTP resource was found that matches the request URI 'https://management.azure.com/subscriptions/<subscr_id>/resourceGroups/subscriptions/<subscr_id>/resourceGroups/doodad5effac/providers/Microsoft.Compute/disks/doodad-vm-disk?api-version=2020-05-01'.

I will be grateful for any hints!

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 2, 2021
@tjprescott tjprescott added the Mgmt This issue is related to a management-plane library. label Aug 3, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 3, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Aug 3, 2021
@tjprescott tjprescott added the Service Attention Workflow: This issue is responsible by Azure service team. label Aug 3, 2021
@ghost
Copy link

ghost commented Aug 3, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Drewm3, @avirishuv.

Issue Details

My previous issue #19786 was closed an I was unable to reopen it so I am opening here a new one.

Could you help me to specify the platform image parameters to use if I want to create a disk from the platform image (Ubuntu 18.04)? For now I was passing:

                'storage_profile': {
                    'image_reference': {
                        "offer": "UbuntuServer",
                        "publisher": "Canonical",
                        "sku": "18.04-LTS",
                        "urn": "Canonical:UbuntuServer:18.04-LTS:latest",
                        "urnAlias": "UbuntuLTS",
                        "version": "latest"
                    }
                },

But since 'image_reference is now osdisk I have tried passing this information in the 'creation_data':

                'creation_data': {
                    'create_option': 'from_image',
                    "id": "/Subscriptions/{}/Providers/Microsoft.Compute/Locations/westus/Publishers/Canonical/ArtifactTypes/VMImage/Offers/UbuntuServer/Skus/18.04-LTS/Versions/latest".format(self.subscription_id),
                }
            }

following this reference: https://docs.microsoft.com/en-us/rest/api/compute/disks/create-or-update#create-a-managed-disk-from-a-platform-image.
But I am getting:

Operation failed with status: 'Not Found'. Details: No HTTP resource was found that matches the request URI 'https://management.azure.com/subscriptions/<subscr_id>/resourceGroups/subscriptions/<subscr_id>/resourceGroups/doodad5effac/providers/Microsoft.Compute/disks/doodad-vm-disk?api-version=2020-05-01'.

I will be grateful for any hints!

Author: Jendker
Assignees: -
Labels:

Compute - VM, Mgmt, Service Attention, customer-reported, needs-team-attention, question

Milestone: -

@tjprescott
Copy link
Member

Adding @Vaibhav-Agar who worked on the other issue.

@RAY-316 RAY-316 self-assigned this Aug 9, 2021
@RAY-316
Copy link
Contributor

RAY-316 commented Aug 9, 2021

hi @Jendker I successfully created the disk with this parameter

diskParams = {
        'location': "West US",
        "properties": {
            "osType": "Linux",
            "creationData": {
                "createOption": "FromImage",
                "imageReference": {
                    "id": "/Subscriptions/{}/Providers/Microsoft.Compute/Locations/westus/Publishers/Canonical/ArtifactTypes/VMImage"
                          "/Offers/UbuntuServer/Skus/18.04-LTS/Versions/latest".format(subscription_id)
                }
            }
        }
    }

@Jendker
Copy link
Author

Jendker commented Aug 9, 2021

Thank you for your answer!
I am still getting following error:

Operation failed with status: 'Not Found'. Details: No HTTP resource was found that matches the request URI 'https://management.azure.com/subscriptions/6c8075ac-6804-4336-8a99-50c71ce3faf3/resourceGroups/subscriptions/6c8075ac-6804-4336-8a99-50c71ce3faf3/resourceGroups/doodad116c87/providers/Microsoft.Compute/disks/doodad-vm-disk?api-version=2020-05-01'.

My presumption is that we are using too old API which does not support this functionality (we are using older azure-mgmt-storage==11.2.0, otherwise we would need to rewrite a large portion of our interface). Do you know what is the first azure-mgmt-storage version which supports this functionality so that I can test if it still works with our code?

@Vaibhav-Agar
Copy link

@tjprescott or @RAY-316 do either of you know?

@Jendker
Copy link
Author

Jendker commented Aug 30, 2021

Just wanted to remind about this issue @tjprescott @RAY-316

@oriwolman oriwolman assigned oriwolman and unassigned Vaibhav-Agar Oct 8, 2021
@SaurabhSharma-MSFT
Copy link
Member

@tjprescott @RAY-316 Gentle reminder to look into this issue.

@RAY-316 RAY-316 added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Dec 15, 2021
@ghost
Copy link

ghost commented Dec 15, 2021

Hi @Jendker. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost ghost removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Dec 15, 2021
@Jendker
Copy link
Author

Jendker commented Dec 15, 2021

I don’t think the issue has been addressed yet. Could you please answer my question from #20044 (comment) ? /unresolve

@ghost ghost added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. labels Dec 15, 2021
@BigCat20196
Copy link
Contributor

Hi @Jendker, azure-mgmt-container-11.2.0 corresponds to track1 version. The last version of azure-mgmt-compute that supports track1 is 14.0.0.

However, the update and maintenance of track1 has stopped. It is strongly recommended that you upgrade to the latest version. Although you may need to rewrite some code, track2 will bring you a better experience.

@Jendker
Copy link
Author

Jendker commented Jan 20, 2022

Thank you for the response! Closing now.

@Jendker Jendker closed this as completed Jan 20, 2022
@BigCat20196 BigCat20196 self-assigned this Jan 21, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Sep 22, 2022
Merge Microsoft.app 2022 06 01 preview to main (Azure#20787)

* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Add app diag to 2022-05-01 (Azure#18678)

* Add container apps diagnostics

* Fix validation errors

* Move Microsoft.App diag APIs to 2022-05-01

* Fix validation errors

* Fix validation errors

* Fix validation errors 3

* Change operationIds

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix definition for customhostnameesult (Azure#19014)

* fix

* update

* more fix

* Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048)

* Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example

* Fix the casing of enums in the latest api version

* Change the parameter names to unblock Terraform release (Azure#19005)

* contianerapps: fixing swagger inconsistencies in 2022-01-01-preview

* containerapps: fixing inconsistencies in the 2022-03-01 swagger

* containerapps: updating the examples for 2022-01-01-preview

* containerapps: updating the examples to account for the updated parameter names

* containerapps: fixing linting

* fix probe enums

* Fix revision mode enum

* Fix the policheck error

* Revert "containerapps: fixing linting"

This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8.

* Revert "containerapps: updating the examples for 2022-01-01-preview"

This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c.

* Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"

This reverts commit 553fc551b3239598157238ed6246085748421b87.

* Undo changes to 2022-01-01-preview

* Fix one issue

* fix remaining inconsistency

* fix authConfig and sourceControl names

Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Mike Vu <mikevu@microsoft.com>

* Change param names

* Fix examples

* Fix CI errors

Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>

* Fix description in all API versions (Azure#19313)

* Fix description for ManagedEnvironment.Internal property (Azure#19307)

* Fix descriptions in all api versions

* Add traffic info to revisions api (Azure#19054)

* Add traffic info to a revision api

* Add deprecated prop

* Prettier fixes

* 1pdate based on new proposal

* Rename

* Change names

* minor fix

* Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360)

* Add httpReadBufferSize to dapr config

* remove nullable

* Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new resources for 2022-06-01-preview (Azure#19494)

* update

* update

* update

* fix

* update

* update

* update

* update

* fix

* update

* update

* Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974)

* Enable Dapr AI Connection string for Microsoft.App connected environment

* Fix dapr ai connection string

* remove read

* remove read permission of dapr ai connection string and instrument key for managed environment

* fixes for comments

* update (Azure#20013)

* Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133)

* Fix casing for detector properties

* Fix descriptions

* Fix descriptions and detectorProperties in 2022-06-01-preview

* Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044)

* Added `secretsStoreComponent` in 2022-06-01 spec

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed typos and added example of name/key

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Add custom domain configuration for managed environment (Azure#20149)

Co-authored-by: Mengjun Qin <menqin@microsoft.com>

* Add additional Dapr options (2022-06-01-preview) (Azure#19886)

* Add additional Dapr options

* Update examples for 2022-06-01-preview

* force ci

* force ci

* force ci

* adding ip-restriction feat (Azure#19841)

* adding ip-restriction feat

* remove from stable, add to preview

* fix lintDiff error

* fix modelvalidation error

* fix formatting changes

* rename names, add note to all allow or all deny

* fix spell check error

* update name and examples

* rename `ipAddress` to `ipAddressRange`

* making small change to re-run build pipeline

* trigger GitHub actions

* resolve comments

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261)

* Revert "Add traffic info to revisions api (Azure#19054)"

This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b.

* Remove traffic labels from revisions

* Add property for tcp apps (Azure#20193)

* Add property for tcp apps

* Add scale

* Fix

* Fix

* Add Init Containers to common definitions (Azure#19855)

* add init containers to common definitions

* move changes to 06-01 preview

* remove repeated container definition

* fix allof syntax

* fix anonymous container definition

* fix lintdiff errors

* fix container allof syntax

* add more init examples

* split baseContainer definition

* remove description

Co-authored-by: p-bouchon <pbouchon@microsoft.com>

* Update container app provisioningstate (Azure#20411)

* update

* update

* add property: maxInactiveRevisions (Azure#20334)

* add property: maxInactiveRevisions

* update

* update

* Add premium sku related properties for managed environment (Azure#19770)

* Add premium sku related properties for managed environment

* Move sku to base property

* Add workloadProfileType

* Examples for managed environment

* Add container app example

* Fix workloadProfiles

* Add custom word

* Fix WorkloadProfileType references

* prettier fixes

* Fix workload profile

* Fix typo

* remove readonly property for workload profile

* Add object type

* nit: Fix description location

* Fix XmsIdentifierValidation

* Remove spaces from enum values

* Remove unwanted change

* Add aka ms url

* Update examples for workload profile type

* Fix rebase issue

* Fix json

* Update description and move location

* Remove provisioning state for node pool

* sku capacity explanation

* Remove capacity attribute

* Remove capacity attribute from required

* Mark sku property as required

* Add x-ms-identifiers

* Rename mimum and maximum

* Rename skutype to skuName

* Make sku property as optional

* Make workload profile type as string

* fix go SDK automation config

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Fix source control status code in 2022-06-01-preview. (Azure#20429)

* Remove 20220501 because we will not support it in server side (Azure#20427)

* remove

* update

* Added support for user defined routing (Azure#20464)

* Added support for user defined routing

* Added examples

* fixed JSON syntax

* syntax fix

* fixed vnetenvironment syntax

* fixed camel case

* case fix

* enum syntax

* fixed comma cases ManagedEnvironmentOutBoundType

* fixing casing

* Some more APIs (Azure#20448)

* new APIs to 06-01

* test fix

* more fixes

* add last active time for revision (Azure#20658)

* Add custom domain for connected env (Azure#20731)

* add custom domain

* fhcekout

* billingMeters - GET endpoint (Azure#20485)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* add proxy resource properties

* Response formatting

* add default error response

* ARM Review feedback + small naming change for a property

* Change GB to GiB

* Fix 2022-06-01-preview branch merge conflicts (Azure#20773)

* Reset

* more fixes

* More fixes

* another conflict fix

* Fix old preview version

* fix 2022-03-01

* supress lint

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Mengjun Qin <767524684@qq.com>
Co-authored-by: Mengjun Qin <menqin@microsoft.com>
Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: p-bouchon <pbouchon@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: JJ <jijohn@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Sep 27, 2022
Rename Post Action and Add Secrets Tags (Azure#20775)

* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Add app diag to 2022-05-01 (Azure#18678)

* Add container apps diagnostics

* Fix validation errors

* Move Microsoft.App diag APIs to 2022-05-01

* Fix validation errors

* Fix validation errors

* Fix validation errors 3

* Change operationIds

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix definition for customhostnameesult (Azure#19014)

* fix

* update

* more fix

* Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048)

* Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example

* Fix the casing of enums in the latest api version

* Change the parameter names to unblock Terraform release (Azure#19005)

* contianerapps: fixing swagger inconsistencies in 2022-01-01-preview

* containerapps: fixing inconsistencies in the 2022-03-01 swagger

* containerapps: updating the examples for 2022-01-01-preview

* containerapps: updating the examples to account for the updated parameter names

* containerapps: fixing linting

* fix probe enums

* Fix revision mode enum

* Fix the policheck error

* Revert "containerapps: fixing linting"

This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8.

* Revert "containerapps: updating the examples for 2022-01-01-preview"

This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c.

* Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"

This reverts commit 553fc551b3239598157238ed6246085748421b87.

* Undo changes to 2022-01-01-preview

* Fix one issue

* fix remaining inconsistency

* fix authConfig and sourceControl names

Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Mike Vu <mikevu@microsoft.com>

* Change param names

* Fix examples

* Fix CI errors

Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>

* Fix description in all API versions (Azure#19313)

* Fix description for ManagedEnvironment.Internal property (Azure#19307)

* Fix descriptions in all api versions

* Add traffic info to revisions api (Azure#19054)

* Add traffic info to a revision api

* Add deprecated prop

* Prettier fixes

* 1pdate based on new proposal

* Rename

* Change names

* minor fix

* Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360)

* Add httpReadBufferSize to dapr config

* remove nullable

* Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new resources for 2022-06-01-preview (Azure#19494)

* update

* update

* update

* fix

* update

* update

* update

* update

* fix

* update

* update

* Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974)

* Enable Dapr AI Connection string for Microsoft.App connected environment

* Fix dapr ai connection string

* remove read

* remove read permission of dapr ai connection string and instrument key for managed environment

* fixes for comments

* update (Azure#20013)

* Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133)

* Fix casing for detector properties

* Fix descriptions

* Fix descriptions and detectorProperties in 2022-06-01-preview

* Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044)

* Added `secretsStoreComponent` in 2022-06-01 spec

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed typos and added example of name/key

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Add custom domain configuration for managed environment (Azure#20149)

Co-authored-by: Mengjun Qin <menqin@microsoft.com>

* Add additional Dapr options (2022-06-01-preview) (Azure#19886)

* Add additional Dapr options

* Update examples for 2022-06-01-preview

* force ci

* force ci

* force ci

* adding ip-restriction feat (Azure#19841)

* adding ip-restriction feat

* remove from stable, add to preview

* fix lintDiff error

* fix modelvalidation error

* fix formatting changes

* rename names, add note to all allow or all deny

* fix spell check error

* update name and examples

* rename `ipAddress` to `ipAddressRange`

* making small change to re-run build pipeline

* trigger GitHub actions

* resolve comments

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261)

* Revert "Add traffic info to revisions api (Azure#19054)"

This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b.

* Remove traffic labels from revisions

* Add property for tcp apps (Azure#20193)

* Add property for tcp apps

* Add scale

* Fix

* Fix

* Add Init Containers to common definitions (Azure#19855)

* add init containers to common definitions

* move changes to 06-01 preview

* remove repeated container definition

* fix allof syntax

* fix anonymous container definition

* fix lintdiff errors

* fix container allof syntax

* add more init examples

* split baseContainer definition

* remove description

Co-authored-by: p-bouchon <pbouchon@microsoft.com>

* Update container app provisioningstate (Azure#20411)

* update

* update

* add property: maxInactiveRevisions (Azure#20334)

* add property: maxInactiveRevisions

* update

* update

* Add premium sku related properties for managed environment (Azure#19770)

* Add premium sku related properties for managed environment

* Move sku to base property

* Add workloadProfileType

* Examples for managed environment

* Add container app example

* Fix workloadProfiles

* Add custom word

* Fix WorkloadProfileType references

* prettier fixes

* Fix workload profile

* Fix typo

* remove readonly property for workload profile

* Add object type

* nit: Fix description location

* Fix XmsIdentifierValidation

* Remove spaces from enum values

* Remove unwanted change

* Add aka ms url

* Update examples for workload profile type

* Fix rebase issue

* Fix json

* Update description and move location

* Remove provisioning state for node pool

* sku capacity explanation

* Remove capacity attribute

* Remove capacity attribute from required

* Mark sku property as required

* Add x-ms-identifiers

* Rename mimum and maximum

* Rename skutype to skuName

* Make sku property as optional

* Make workload profile type as string

* fix go SDK automation config

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Fix source control status code in 2022-06-01-preview. (Azure#20429)

* Remove 20220501 because we will not support it in server side (Azure#20427)

* remove

* update

* Added support for user defined routing (Azure#20464)

* Added support for user defined routing

* Added examples

* fixed JSON syntax

* syntax fix

* fixed vnetenvironment syntax

* fixed camel case

* case fix

* enum syntax

* fixed comma cases ManagedEnvironmentOutBoundType

* fixing casing

* Some more APIs (Azure#20448)

* new APIs to 06-01

* test fix

* more fixes

* add last active time for revision (Azure#20658)

* Add custom domain for connected env (Azure#20731)

* add custom domain

* fhcekout

* billingMeters - GET endpoint (Azure#20485)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* add proxy resource properties

* Response formatting

* add default error response

* ARM Review feedback + small naming change for a property

* Change GB to GiB

* Rename Action

* secrets tag

* missed fix

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Mengjun Qin <767524684@qq.com>
Co-authored-by: Mengjun Qin <menqin@microsoft.com>
Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: p-bouchon <pbouchon@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: JJ <jijohn@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Sep 28, 2022
Availableworkloadprofiles - GET endpoint (Azure#20650)

* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Add app diag to 2022-05-01 (Azure#18678)

* Add container apps diagnostics

* Fix validation errors

* Move Microsoft.App diag APIs to 2022-05-01

* Fix validation errors

* Fix validation errors

* Fix validation errors 3

* Change operationIds

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix definition for customhostnameesult (Azure#19014)

* fix

* update

* more fix

* Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048)

* Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example

* Fix the casing of enums in the latest api version

* Change the parameter names to unblock Terraform release (Azure#19005)

* contianerapps: fixing swagger inconsistencies in 2022-01-01-preview

* containerapps: fixing inconsistencies in the 2022-03-01 swagger

* containerapps: updating the examples for 2022-01-01-preview

* containerapps: updating the examples to account for the updated parameter names

* containerapps: fixing linting

* fix probe enums

* Fix revision mode enum

* Fix the policheck error

* Revert "containerapps: fixing linting"

This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8.

* Revert "containerapps: updating the examples for 2022-01-01-preview"

This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c.

* Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"

This reverts commit 553fc551b3239598157238ed6246085748421b87.

* Undo changes to 2022-01-01-preview

* Fix one issue

* fix remaining inconsistency

* fix authConfig and sourceControl names

Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Mike Vu <mikevu@microsoft.com>

* Change param names

* Fix examples

* Fix CI errors

Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>

* Fix description in all API versions (Azure#19313)

* Fix description for ManagedEnvironment.Internal property (Azure#19307)

* Fix descriptions in all api versions

* Add traffic info to revisions api (Azure#19054)

* Add traffic info to a revision api

* Add deprecated prop

* Prettier fixes

* 1pdate based on new proposal

* Rename

* Change names

* minor fix

* Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360)

* Add httpReadBufferSize to dapr config

* remove nullable

* Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new resources for 2022-06-01-preview (Azure#19494)

* update

* update

* update

* fix

* update

* update

* update

* update

* fix

* update

* update

* Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974)

* Enable Dapr AI Connection string for Microsoft.App connected environment

* Fix dapr ai connection string

* remove read

* remove read permission of dapr ai connection string and instrument key for managed environment

* fixes for comments

* update (Azure#20013)

* Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133)

* Fix casing for detector properties

* Fix descriptions

* Fix descriptions and detectorProperties in 2022-06-01-preview

* Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044)

* Added `secretsStoreComponent` in 2022-06-01 spec

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed typos and added example of name/key

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Add custom domain configuration for managed environment (Azure#20149)

Co-authored-by: Mengjun Qin <menqin@microsoft.com>

* Add additional Dapr options (2022-06-01-preview) (Azure#19886)

* Add additional Dapr options

* Update examples for 2022-06-01-preview

* force ci

* force ci

* force ci

* adding ip-restriction feat (Azure#19841)

* adding ip-restriction feat

* remove from stable, add to preview

* fix lintDiff error

* fix modelvalidation error

* fix formatting changes

* rename names, add note to all allow or all deny

* fix spell check error

* update name and examples

* rename `ipAddress` to `ipAddressRange`

* making small change to re-run build pipeline

* trigger GitHub actions

* resolve comments

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261)

* Revert "Add traffic info to revisions api (Azure#19054)"

This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b.

* Remove traffic labels from revisions

* Add property for tcp apps (Azure#20193)

* Add property for tcp apps

* Add scale

* Fix

* Fix

* Add Init Containers to common definitions (Azure#19855)

* add init containers to common definitions

* move changes to 06-01 preview

* remove repeated container definition

* fix allof syntax

* fix anonymous container definition

* fix lintdiff errors

* fix container allof syntax

* add more init examples

* split baseContainer definition

* remove description

Co-authored-by: p-bouchon <pbouchon@microsoft.com>

* Update container app provisioningstate (Azure#20411)

* update

* update

* add property: maxInactiveRevisions (Azure#20334)

* add property: maxInactiveRevisions

* update

* update

* Add premium sku related properties for managed environment (Azure#19770)

* Add premium sku related properties for managed environment

* Move sku to base property

* Add workloadProfileType

* Examples for managed environment

* Add container app example

* Fix workloadProfiles

* Add custom word

* Fix WorkloadProfileType references

* prettier fixes

* Fix workload profile

* Fix typo

* remove readonly property for workload profile

* Add object type

* nit: Fix description location

* Fix XmsIdentifierValidation

* Remove spaces from enum values

* Remove unwanted change

* Add aka ms url

* Update examples for workload profile type

* Fix rebase issue

* Fix json

* Update description and move location

* Remove provisioning state for node pool

* sku capacity explanation

* Remove capacity attribute

* Remove capacity attribute from required

* Mark sku property as required

* Add x-ms-identifiers

* Rename mimum and maximum

* Rename skutype to skuName

* Make sku property as optional

* Make workload profile type as string

* fix go SDK automation config

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Fix source control status code in 2022-06-01-preview. (Azure#20429)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* Remove 20220501 because we will not support it in server side (Azure#20427)

* remove

* update

* add proxy resource properties

* Response formatting

* Added support for user defined routing (Azure#20464)

* Added support for user defined routing

* Added examples

* fixed JSON syntax

* syntax fix

* fixed vnetenvironment syntax

* fixed camel case

* case fix

* enum syntax

* fixed comma cases ManagedEnvironmentOutBoundType

* fixing casing

* add default error response

* Add available workprofiles -GET endpoint

* Remove duplicate schema name WorkloadProfile

* Change memoryGiB to memoryGB as suggested in code review

* Add x-ms-pageable - nextLink support to not introduce breaking changes in the future

* rename to memory in GiB because our case is Gibibytes base 1024

* change friendlyName to displayName

* Some more APIs (Azure#20448)

* new APIs to 06-01

* test fix

* more fixes

* Add new property to the response object

* add last active time for revision (Azure#20658)

* Add custom domain for connected env (Azure#20731)

* add custom domain

* fhcekout

* billingMeters - GET endpoint (Azure#20485)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* add proxy resource properties

* Response formatting

* add default error response

* ARM Review feedback + small naming change for a property

* Change GB to GiB

* Change the boolean value for default to enum

* change error response to v3/ErrorResponse

* Fix 2022-06-01-preview branch merge conflicts (Azure#20773)

* Reset

* more fixes

* More fixes

* another conflict fix

* Fix old preview version

* fix 2022-03-01

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Mengjun Qin <767524684@qq.com>
Co-authored-by: Mengjun Qin <menqin@microsoft.com>
Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: p-bouchon <pbouchon@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: JJ <jijohn@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Compute - VM customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

9 participants