Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependency for azure-common #11407

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Add missing dependency for azure-common #11407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b470197
Add missing dependency for azure-common
ad-m May 13, 2020
82300e0
Import on scope to reduce dependencies
ad-m May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/core/azure-common/azure/common/client_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
except ImportError:
from inspect import getargspec as get_arg_spec

import adal
from msrestazure.azure_active_directory import AdalAuthentication

from .credentials import get_azure_cli_credentials
from .cloud import get_cli_active_cloud

Expand Down Expand Up @@ -153,6 +150,9 @@ def get_client_from_json_dict(client_class, config_dict, **kwargs):
:param dict config_dict: A config dict.
:return: An instantiated client
"""
import adal
from msrestazure.azure_active_directory import AdalAuthentication

is_graphrbac = client_class.__name__ == 'GraphRbacManagementClient'
is_keyvault = client_class.__name__ == 'KeyVaultClient'
parameters = {
Expand Down