Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[textanalytics] check for model version/stats in response hook policy #11797

Merged
merged 1 commit into from
Jun 4, 2020
Merged

[textanalytics] check for model version/stats in response hook policy #11797

merged 1 commit into from
Jun 4, 2020

Conversation

kristapratico
Copy link
Member

@kristapratico kristapratico commented Jun 3, 2020 •
edited
Loading

With new data limits of v3.0 of service, we are hitting the rate limit more frequently in tests. We retry on 429s and should wait to make the call to the user-provided callback function until properties are populated.

Edit: Last 10 live test passes on this PR: https://dev.azure.com/azure-sdk/internal/_build?definitionId=1314

@kristapratico kristapratico changed the title [DO NOT MERGE] try look for model version/stats [textanalytics] check for model version/stats in response hook policy Jun 3, 2020
@kristapratico kristapratico self-assigned this Jun 3, 2020
@kristapratico kristapratico added Client This issue points to a problem in the data-plane of the library. Cognitive Services TextAnalytics labels Jun 3, 2020
@kristapratico kristapratico marked this pull request as ready for review June 3, 2020 23:38
iscai-msft
iscai-msft approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so so much for doing this :shipit:

@kristapratico kristapratico merged commit d4bd596 into Azure:master Jun 4, 2020
@kristapratico kristapratico deleted the try-ta branch June 4, 2020 17:07
xiangyan99 added a commit that referenced this pull request Jun 4, 2020
@xiangyan99 @aim-for-better
@lmazuel @AutorestCI @azure-sdk @chlowell @annatisch @iscai-msft @kristapratico
get master (#11823)
119e4e8 
* [HDInsight] Fix hdi test failure (#11806)

* Initial generation Synapse autorest v5

* Fix empty model generation

* Fix Test Failure:
Skip 3 test case: test_create_with_adlsgen1, test_create_with_additional_storage, test_oms_on_running_cluster
Rename test_http_extend to test_gateway_setting for http settings is
replaced with gateway settings

Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>

* disable some by design bandit warnings (#11495)

* disable some by design bandit warnings

* Packaging update of azure-mgmt-datalake-analytics

Co-authored-by: Azure SDK Bot <aspysdk2@microsoft.com>

* Increment package version after release of azure_core (#11795)

* Use subject claim as home_account_id when no client_info (#11639)

* Refactor ClientCertificateCredential to use AadClient (#11719)

* Refactor ClientSecretCredential to use AadClient (#11718)

* [Cosmos] Fixed incorrect ID type error (#11798)

* Fixed incorrect ID type error

* Fix pylint

* [text analytics] Update readme (#11796)

* try something (#11797)

* Search refactoring 3 (#11804)

* create_or_update takes object

* rename is_hidden to hidden

* fix types

* updates

Co-authored-by: aim-for-better <zhenyu.zhou@microsoft.com>
Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Co-authored-by: Azure SDK Bot <aspysdk2@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
xiangyan99 added a commit that referenced this pull request Jun 5, 2020
@xiangyan99 @chlowell
@aim-for-better @lmazuel @AutorestCI @azure-sdk @annatisch @iscai-msft @kristapratico
code refactoring 4 (#11800)
5c4dc31 
* search method only takes search_text

* update

* Add AzureCliCredential and VSCodeCredential to public API (#11790) (#11805)

Co-authored-by: Charles Lowell <chlowe@microsoft.com>

* get master (#11823)

* [HDInsight] Fix hdi test failure (#11806)

* Initial generation Synapse autorest v5

* Fix empty model generation

* Fix Test Failure:
Skip 3 test case: test_create_with_adlsgen1, test_create_with_additional_storage, test_oms_on_running_cluster
Rename test_http_extend to test_gateway_setting for http settings is
replaced with gateway settings

Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>

* disable some by design bandit warnings (#11495)

* disable some by design bandit warnings

* Packaging update of azure-mgmt-datalake-analytics

Co-authored-by: Azure SDK Bot <aspysdk2@microsoft.com>

* Increment package version after release of azure_core (#11795)

* Use subject claim as home_account_id when no client_info (#11639)

* Refactor ClientCertificateCredential to use AadClient (#11719)

* Refactor ClientSecretCredential to use AadClient (#11718)

* [Cosmos] Fixed incorrect ID type error (#11798)

* Fixed incorrect ID type error

* Fix pylint

* [text analytics] Update readme (#11796)

* try something (#11797)

* Search refactoring 3 (#11804)

* create_or_update takes object

* rename is_hidden to hidden

* fix types

* updates

Co-authored-by: aim-for-better <zhenyu.zhou@microsoft.com>
Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Co-authored-by: Azure SDK Bot <aspysdk2@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>

* rename AnalyzeText to AnalyzeTextRequest

* fixes

* update

* update changelog

* update

* add types

* update

* rename batch methods

* update

* update

* update

* updates

Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: aim-for-better <zhenyu.zhou@microsoft.com>
Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Co-authored-by: Azure SDK Bot <aspysdk2@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: annatisch <antisch@microsoft.com>
Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft approved these changes

Assignees

@kristapratico kristapratico

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics Cognitive Services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristapratico @iscai-msft