Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent caching for service principal credentials #11824

Merged
merged 6 commits into from
Jun 5, 2020
Merged

Persistent caching for service principal credentials #11824

merged 6 commits into from
Jun 5, 2020

Conversation

chlowell
Copy link
Member

@chlowell chlowell commented Jun 4, 2020

Adds optional persistent caching to CertificateCredential and ClientSecretCredential, configured by keyword arguments enable_persistent_cache and allow_unencrypted_cache, both False by default.

Cache locations:

  • Linux: libsecret
    • schema name "msal.confidential.cache", label "MSALConfidentialCache", attribute "MsalClientID": "Microsoft.Developer.IdentityService"
    • signal file: ~/.IdentityService/msal.confidential.cache
      • plaintext fallback is the same (yes, a new encrypted cache clobbers an unencrypted one)
  • macOS: Keychain service "Microsoft.Developer.IdentityService", account "MSALConfidentialCache"
    • signal file: ~/.IdentityService/msal.confidential.cache
  • Windows: %LOCALAPPDATA%/.IdentityService/msal.confidential.cache

Closes #11347

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Jun 4, 2020
@chlowell chlowell requested a review from xiangyan99 June 4, 2020 18:10
@chlowell chlowell requested a review from schaabs as a code owner June 4, 2020 18:10
@chlowell chlowell requested a review from jianghaolu June 4, 2020 23:22
jianghaolu
jianghaolu previously approved these changes Jun 4, 2020
View reviewed changes
@chlowell chlowell merged commit b15cede into Azure:master Jun 5, 2020
@chlowell chlowell deleted the sp-token-cache branch June 5, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@jianghaolu jianghaolu jianghaolu left review comments

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persistent token cache for service principals
3 participants
@chlowell @jianghaolu @xiangyan99