Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EventgridSharedAccessSignatureCredential with AzureSasCredential #16147

Merged
merged 8 commits into from
Jan 15, 2021

Conversation

rakshith91
Copy link
Contributor

@rakshith91 rakshith91 commented Jan 13, 2021

Fixes #15938

Consuming the AzureSasCredential in lieu of EventgridSharedAccessSignatureCredential

@ghost ghost added the Event Grid label Jan 13, 2021
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91 rakshith91 marked this pull request as ready for review January 15, 2021 15:45
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

1 similar comment
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakshith91 rakshith91 merged commit e4c4daa into Azure:master Jan 15, 2021
@rakshith91 rakshith91 deleted the sascredeg branch January 15, 2021 22:29
rakshith91 added a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jan 15, 2021
…ial (Azure#16147)

* AzureSasCred

* fix

* Update sdk/eventgrid/azure-eventgrid/azure/eventgrid/_signature_credential_policy.py

* Update sdk/eventgrid/azure-eventgrid/azure/eventgrid/_signature_credential_policy.py

* sample

* changelog

* test async

* Apply suggestions from code review
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jan 20, 2021
…into fix_autorest_links

* 'master' of https://github.com/Azure/azure-sdk-for-python: (44 commits)
  Added credscan steps for python (Azure#16136)
  [Communication] Move core dependency to setup.py from dev_requirements in communication management package (Azure#16077)
  Increment package version after release of azure_security_attestation (Azure#16218)
  T2 compute 2021 01 19 (Azure#16246)
  Update error message in tools repo (Azure#16245)
  Add LanguageDisplayName variable to LanguageSettings file (Azure#16239)
  Fix Eventgrid sample (Azure#16217)
  Adding 2020-09-01-hybrid profile (Azure#14642)
  Increment version for storage releases (Azure#16152)
  Increment package version after release of azure_storage_file_datalake (Azure#16157)
  make the globbing of the packages work in dev_setup from any invocation directory (Azure#16209)
  [Queues] Generated Queues using newest autorest version (Azure#16148)
  T2 confluent 2021 01 15 (Azure#16221)
  we are using a pool not a specific vmImage (Azure#16213)
  Naming Feedback - part 2 (Azure#16210)
  Naming feedback - part 1 (Azure#16208)
  Raise on bad credential (Azure#16206)
  Updated release date (Azure#16205)
  Required params must be positional (Azure#16194)
  Replace EventgridSharedAccessSignatureCredential with AzureSasCredential (Azure#16147)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming EventGridSharedAccessSignatureCredential 
2 participants