-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
append code coverage over each other #16202
Merged
Merged
Changes from all commits
Commits
Show all changes
109 commits
Select commit
Hold shift + click to select a range
56283b6
append code coverage over each other
seankane-msft 7978574
does not need a True
seankane-msft fad5073
adding append to the coverage combine call
seankane-msft 1167210
adding the append to code coverage in the tox.ini file
seankane-msft 41642b2
forgot to add the cov-append arg
seankane-msft 2a107e3
publish the _coverage file
seankane-msft 824ade0
changing path to coverage for publishing
seankane-msft 539ff5e
adding append to coverage combine, not moving to the root directory n…
seankane-msft 90dbbdc
changing to fileSharePath input for a folder
seankane-msft f70fe46
filePath was not the right keyword, should have been pipeline
seankane-msft 6ef9d47
wrong way on a slash
seankane-msft 63679ce
removing another coverage combine call
seankane-msft 35679be
found a second coverage combine call, commenting out and re-trying
seankane-msft 8125fa4
adding a stage after build for code coverage
seankane-msft 169fb65
removing extra step
seankane-msft bf579ae
adding download step to get all generated .coverage files
seankane-msft 613f8e4
changing script to pwsh
seankane-msft f1f6941
changed condition, download everything from the pipeline uploads
seankane-msft 241d906
added python script for combining coverage files
seankane-msft cfec863
fixed a syntax error
seankane-msft e6a1e3d
ended up having the wrong directory in python script
seankane-msft 2763f9b
error in python script and yml file
seankane-msft 2511e60
moving to a stage that depends on build, fixed python script
seankane-msft e2176b0
fixing yml syntax errors, adding params to the publish-coverage.yml file
seankane-msft 125838d
moving publish coverage to templates, attempt to fix syntax error
seankane-msft 923ed2f
added job and steps portions to yaml
seankane-msft 79c2ff8
moving depends on to publish-coverage.yml file
seankane-msft eeec8ec
adding runcoverage as a default argument
seankane-msft 34b1ebe
fixed a naming issue, added empty job
seankane-msft 1194bae
fixed more naming issues
seankane-msft a00b2d0
moving dependsOn around
seankane-msft 6340348
publishing .coverage in the CI pipeline
seankane-msft 005b0e4
installing coverage package in script, adding disable-cov arguments f…
seankane-msft 082d804
had the wrong command line arg for disable cov
seankane-msft f3718a9
changing live tests to be a staged job
seankane-msft d6d3b37
fixing the appconfig tests.yml file
seankane-msft 8e40e61
changing EnvVars to have a full description
seankane-msft 841722f
changing parameters to have full info type and default
seankane-msft 5468705
trying to figure out params
seankane-msft 0162da3
changing params in the jobs file
seankane-msft 7c1b31f
fixed parameters in the templates/jobs file, making sure it is correc…
seankane-msft 8832b17
adding params to the stages file, fixing the appconfig tests.yml file
seankane-msft 1ef3ebd
fixed a spacing issue
seankane-msft 0ba995d
fixing up create coverage.py file
seankane-msft 3637010
forgot the directory for the coverage install
seankane-msft fe6fbdc
fixing a merge conflict
seankane-msft be75131
commenting out the pool for now
seankane-msft a470e72
adding the pool to the stages yml file
seankane-msft d0660b5
removing the publish step, .coverage files are published in the build…
seankane-msft 2034b4c
setting the version of coverage
seankane-msft b136e2c
raise error on failure
seankane-msft 2ee5f5e
generating code coverage xml via powershell
seankane-msft 24f9e50
adding step to find where the .coverage file is being published to
seankane-msft 1eae302
changing regex, listing all files in working directory
seankane-msft f93b115
changed the running dir to the root instead of the coverage_dir
seankane-msft ae82df3
removing the raise exception on run_check_call in gen_cov_xml()
seankane-msft 045ceda
cleaning up yml files for ben to branch off of
seankane-msft 02840d9
removing --appends, coverage file is not generating correctly
seankane-msft 7cffffc
adding check to see if coverage is generated blank
seankane-msft 3acabcc
changing pwsh cmd to see what the .coverage files look like after Run…
seankane-msft f88f7da
added a new python script to change the file structure
seankane-msft e35217f
cleaning up some unnecessary commands
seankane-msft f031835
changing the storage test pipeline
seankane-msft f16bacd
merge conflict
seankane-msft e60a29f
undoing changes to storage tests
seankane-msft 978efc2
trying tox in parallel mode
seankane-msft 6dd6722
removing comment, no comments in tox files i guess
seankane-msft 91b1662
moving --parallel-mode to the yml file
seankane-msft a0a5743
undoing changes, parallel mode does not work with pytest-cov
seankane-msft 045241d
ideas from krista
seankane-msft de63dff
Update eng/pipelines/templates/jobs/publish-coverage.yml
seankane-msft 5a8d846
Merge branch 'append-code-cov' of https://github.com/Azure/azure-sdk-…
seankane-msft 54cd83d
moving pip install to different step
seankane-msft c02ca67
fixing syntax error
seankane-msft c220147
making a change based on response to filed issue
seankane-msft 93bde28
updating paths portion of .coveragerc
seankane-msft 08cb29f
changed eventhub test.yml file too
seankane-msft 4dec3b3
syntax error
seankane-msft 2454baf
changing to stages instead of extends, thanks ben broderick
seankane-msft 26baa25
adding step to show entire .coverage files
seankane-msft fc86a18
fixing up powershell script
seankane-msft 6bee0f6
fixing part where mgmt package was not being included because it was …
seankane-msft 68e4a9e
fixed the python script a bit
seankane-msft a0e09f5
cleaning up create_coverage.py script
seankane-msft fdbc0d0
addressing comments from ben and wes
seankane-msft d9d1a31
removing commented out sections
seankane-msft ef88e77
making changes to keyvault and storage
seankane-msft 0138364
changing the yml path being pointed to
seankane-msft 27e1aca
Use unique stage names for live tests (#16454)
benbp 9add276
adjusting sdk tests.yml files
seankane-msft 735d0b8
removing default test matrix params from jobs/archetype-sdk-tests.yml…
seankane-msft d8ffb63
reverting last change
seankane-msft 9d6c925
adding a step to pip install all the ci tools
seankane-msft d4a4d4e
fixing up the storage file
seankane-msft 5af7981
changing the storage tests.yml file
seankane-msft 3cda15d
adding a pip list
seankane-msft 4055cfb
using pip install from the build-test yml file
seankane-msft 5af79b7
adding -i flag back
seankane-msft de9ba2e
adding a step to pin to python 3.7 and always run on ubuntu 18.04
seankane-msft ce74997
fixing syntax errors
seankane-msft 73f2dae
lowercase p in pool
seankane-msft cdbfadc
addressing scotts comments
seankane-msft 0a60e7f
fixing storages yml files
seankane-msft cefb69f
traded the replace out for a regex
seankane-msft ad8fc63
trying a dependsOn for the keyvault yml file
seankane-msft 62a8250
dependsOn throws a syntax error
seankane-msft 4d27c06
removing runcoverage param
seankane-msft e093972
adding displayName and combining two display methods
seankane-msft 5cf1802
changing jobs -> states
seankane-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,11 @@ omit = | |
*/test* | ||
env* | ||
|
||
[paths] | ||
source = | ||
sdk/ | ||
**/sdk | ||
|
||
[report] | ||
exclude_lines = | ||
pragma: no cover | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
parameters: | ||
- name: ServiceDirectory | ||
type: string | ||
default: '' | ||
- name: Artifacts | ||
type: object | ||
default: [] | ||
- name: DependsOn | ||
type: string | ||
default: '' | ||
|
||
|
||
jobs: | ||
- job: Publish_Code_Coverage | ||
pool: | ||
name: azsdk-pool-mms-ubuntu-1804-general | ||
vmImage: MMSUbuntu18.04 | ||
|
||
steps: | ||
- task: UsePythonVersion@0 | ||
inputs: | ||
versionSpec: '3.7' | ||
|
||
# Download all existing artifacts (most of the time, it's whatever was uploaded before) | ||
- pwsh: | | ||
New-Item -Path $(Build.SourcesDirectory) -Name "_all_coverage_files" -ItemType "directory" | ||
displayName: 'Create all coverages directory' | ||
continueOnError: false | ||
condition: succeededOrFailed() | ||
|
||
- task: DownloadPipelineArtifact@2 | ||
inputs: | ||
source: current | ||
path: '$(Build.SourcesDirectory)/_all_coverage_files' | ||
|
||
- script: | | ||
pip install -r eng/ci_tools.txt | ||
pip freeze | ||
displayName: 'Prep Environment' | ||
|
||
- pwsh: | | ||
Get-ChildItem -Recurse .\_all_coverage_files\ | | ||
ForEach-Object { | ||
If (Test-Path $_ -PathType Leaf) { | ||
Get-Content $_ | ||
} | ||
} | ||
displayName: Show all coverage files | ||
|
||
seankane-msft marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- task: PythonScript@0 | ||
displayName: 'Create Coverage Report' | ||
inputs: | ||
scriptPath: 'scripts/devops_tasks/create_coverage.py' | ||
|
||
- pwsh: | | ||
Get-Content $(Build.SourcesDirectory)\.coverage | ||
Get-Content $(Build.SourcesDirectory)\coverage.xml | ||
continueOnError: true | ||
displayName: Show .coverage and coverage.xml file | ||
|
||
- task: PublishCodeCoverageResults@1 | ||
displayName: 'Publish Code Coverage to DevOps' | ||
continueOnError: true | ||
condition: succeededOrFailed() | ||
inputs: | ||
codeCoverageTool: Cobertura | ||
summaryFileLocation: '$(Build.SourcesDirectory)/coverage.xml' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @benbp I know you are working on refactoring this file and so you will likely conflict with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weshaggard I chatted with Sean and was waiting for these changes to land first, hence why I did Java instead.