Added suppression rules for python #16571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
danieljurek
approved these changes
Feb 10, 2021
|
LGTM. Do you have examples of a build where this passes? I didn't see one when I searched the checks associated w/ the PR. |
@danieljurek The cred scan is in aggregate-report. I have one triggered here: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=740233&view=results |
weshaggard
reviewed
Feb 18, 2021
eng/CredScanSuppression.json
Outdated
| "123_abc", | ||
| "pa$$w0rd", | ||
| "Password1!!!", | ||
| "NzhL3hKZbJBuJ2484dPTR+xF30kYaWSSCbs2BzLgVVI1woqeST/1IgqaLm6QAOTxtGvxctSNbIR/1hW8yH+bJg==", |
There was a problem hiding this comment.
Is this really a placeholder? Some of these look like keys.
There was a problem hiding this comment.
Right, those are symmetricKey. Will remove and work with team to use some static ones.
weshaggard
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.