Skip dumping package proprties to file in test phase #16657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
weshaggard
reviewed
Feb 10, 2021
| @@ -2,8 +2,10 @@ | |||
| # is used when this pipeline is going to be generating and publishing daily dev builds. | |||
| parameters: | |||
| ServiceDirectory: '' | |||
| DumpPackageProperties: true | |||
There was a problem hiding this comment.
This feels like the wrong switch. Why does this fail in test legs?
|
Closing this PR. Issue was transient and reattempt has succeeded. I will check and add a flag in common script to ensure this is triggered only during build step. |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Jan 6, 2022
Web ant95 2021 03 01 (Azure#16506) * Adds base for updating Microsoft.Web from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917) * Introduce enterpriseGradeCdnStatus to StaticSites.json (Azure#16080) * Update StaticSites.json * Update StaticSites.json * Onedeploy API swapper spec (Azure#15985) * Onedeploy API swapper spec * Adding onedeploy custom keyword * Formatting onedeploy api indentation Formatting onedeploy api indentation * prettifier Co-authored-by: Calvin Chan <calvinch4n@gmail.com> * Fix status codes for syncfunctiontriggers (Azure#16413) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web (Azure#16427) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web * Fix duplicate operation ids * Swagger for ASD Transfer out (Azure#16000) * Add domain transfer out to swagger * Prettifier * Add 202 response for webapp restart * Add certificate listHostnameBindingsOfCertificate * Formatting * Swagger for listHostnameBindings endpoint (Azure#16516) * Swagger for listHostnameBindings endpoint * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917) * ops Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * User/jennylaw/containerapp (Azure#16657) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Add custom hostname sites endpoint (Azure#16745) * Add custom hostname sites endpoint * Fix models * Swagger Fixes for Container App, KubeEnvironments spec (Azure#16793) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Fix Kube Environments 2021-03-01 contract + add list secrets api to Container Apps Swagger * Fix sercret read property * Prettier fix * Model fix * Prettier Fix #2 Co-authored-by: Jenny Lawrance <jennylaw@microsoft.com> * Add long running extension for restart (Azure#16791) * Remove unused API from ANT95 swagger (Azure#16901) * Address PR comments (Azure#17019) * Fixing PR comments (Azure#17127) * Remove Certificate Hostname bindings API (Azure#17204) * Remove Certificate Hostname bindings API * Remove examples file as well Co-authored-by: mkarmark <mikarmar@microsoft.com> Co-authored-by: SatishRanjan <SatishRanjan@users.noreply.github.com> Co-authored-by: Calvin Chan <calvinch4n@gmail.com> Co-authored-by: Connor McMahon <comcmaho@microsoft.com> Co-authored-by: JennyLawrance <jennylaw@microsoft.com> Co-authored-by: Sanchit Mehta <sanchit.mehta602@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common script to extract package properties and dump it into file is failing on pypy3 for azure communication pipeline. This PR is to unblock release by skipping this step from test phase. Common change will be submitted to azure-sdk-tools repo in another PR after unblocking python release.