Fixed Content-MD5 serialization and typing #16987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasherif-msft
requested review from
amishra-dev,
annatisch,
kasobol-msft,
xiafu-msft and
zezha-msft
as code owners
ghost
added
the
xiafu-msft
approved these changes
Mar 1, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 1, 2021
…into correct_healthcare * 'master' of https://github.com/Azure/azure-sdk-for-python: (30 commits) [EventGrid] Improve docs (Azure#16986) Fixed delete_blob method signature (Azure#16983) Fixed Content-MD5 serialization and typing (Azure#16987) [eventgrid] Black formatting and tests suite (Azure#16989) Appconfig perf test (Azure#16809) adds support for milliseconds on datetime objects (Azure#16847) [ServiceBus] Improve AMQP Error handling (Azure#16427) T2 resource 2021 02 26 (Azure#16961) T2 servicefabricmanagedclusters 2021 02 26 (Azure#16958) Update Prepare-Release script (Azure#16976) the previous filter was erroneously filtering out real files. (Azure#16978) Update azure-core minimum version (Azure#16968) update documention in depends section of eng_sys_checks.md (Azure#16967) version (Azure#16959) T2 web 2021 02 24 (Azure#16901) Change test pipeline to run in eastus2 (Azure#16950) Adding azure-devtools to mr-auth dev_requirements (Azure#16953) Add perf tests for eventgrid (Azure#16949) temp fix for canary tests (Azure#16945) Update get_package_properties to also return path to setup.py (Azure#16946) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #15919.
Currently the way content-md5 is deserialized is the original bytearray. This is also what the customer is supposed to pass.
At the moment if the user passes content-md5 in
ContentSettings()and passes it toupload_blob()it would throw (pretty bad bug), since we are trying to serialize a passedstrwithout providing encoding type.This serialization is now removed and the customer can directly pass the content-md5 they get from calling
get_blob_peroperties()for example.