Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release of Device Update for IoT Hub SDK for Python. #17005

Merged
merged 27 commits into from
Mar 4, 2021
Merged

Release of Device Update for IoT Hub SDK for Python. #17005

merged 27 commits into from
Mar 4, 2021

Conversation

dpokluda
Copy link
Contributor

@dpokluda dpokluda commented Mar 2, 2021

This is PR with auto-generated SDK for Device Update for IoT Hub. I used the following autorest command:

autorest --python `
--python-sdks-folder=E:\GitHub\azure-sdk-for-python --tag=package-2020-09-01 `
--use=@autorest/python@5.6.1 `
E:\GitHub\azure-rest-api-specs\specification\deviceupdate\data-plane\readme.md

@check-enforcer
Copy link

check-enforcer bot commented Mar 2, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

iscai-msft
iscai-msft reviewed Mar 2, 2021
View reviewed changes
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up creating a PR to your config file with the changes I've mentioned here. Here's the PR. Thanks so much for all of the docs and tests you've added

sdk/deviceupdate/azure-deviceupdate/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/deviceupdate/azure-deviceupdate/README.md Outdated Show resolved Hide resolved
sdk/deviceupdate/azure-deviceupdate/azure/__init__.py Outdated Show resolved Hide resolved
sdk/deviceupdate/azure-deviceupdate/azure/deviceupdate/_configuration.py Outdated Show resolved Hide resolved
sdk/deviceupdate/azure-deviceupdate/azure/deviceupdate/__init__.py Outdated Show resolved Hide resolved
sdk/deviceupdate/azure-deviceupdate/samples/contentfactory.py Outdated Show resolved Hide resolved
@iscai-msft iscai-msft mentioned this pull request Mar 2, 2021
Merged
David Pokluda and others added 12 commits March 2, 2021 13:56
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
8e41822 
…into device-update

# Conflicts:
#	sdk/deviceupdate/ci.yml
Updated readme links.
4da7534
@iscai-msft
fix dev_requirements
32002e2
@iscai-msft
Merge branch 'device-update' of https://github.com/dpokluda/azure-sdk…
f7ff895 
…-for-python into device-update

* 'device-update' of https://github.com/dpokluda/azure-sdk-for-python:
  Updated readme links.
  update artifact names for ALL packages to align with the actual package name
  Create azure-iot-nspkg (#17026)
  [Communication]: SMS 1:N Messages, Custom Tags, and Idempotence (#16836)
  Fixing credentials to use AAD (#16885)
  T2 deviceupdate 2021 03 02 (#17016)
  T2 cosmosdb 2021 02 23 (#16875)
  T2 datadog 2021 03 02 (#17004)
  Fixed STG76 GA setup.py classifier (#17007)
  Resolve Installation Failure in AggregateReports job by updating pip install params (#16999)
@iscai-msft
remove en-us from link in readme
e3ffa53
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
6f8fc1a 
…into device-update

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [device update] allow device update pylint failures (#17034)
  fix build (#17029)
@iscai-msft
switch to powershell preparer, all passing in playback except one
1024efd
@iscai-msft
remove tests. and test_data
246afaa
@iscai-msft
add Azure to top of readme
7b8ee32
@iscai-msft
change device update core requirement in shared_requirements.txt
b07ca58
@iscai-msft
mark scrubbing failure test with live only
aff03ef
@iscai-msft
update date in changelog
5c62fdd
@iscai-msft iscai-msft requested a review from lmazuel March 3, 2021 19:19
lmazuel
lmazuel approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved the PR from a packaging + “quick look at code” + “nice tests” perspective

@iscai-msft iscai-msft merged commit 1c1a995 into Azure:master Mar 4, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
2bb425f 
…into add_query_kwarg

* 'master' of https://github.com/Azure/azure-sdk-for-python: (69 commits)
  march release (Azure#16966)
  Release of Device Update for IoT Hub SDK for Python. (Azure#17005)
  Add Get-AllPackageInfoFromRepo (Azure#16947)
  Track1 package is incorrectly set as track2 (Azure#17075)
  [text analytics] add normalized_text (Azure#17074)
  Renaming with_token identity function (Azure#17066)
  Adapt to azure core's cloud event (Azure#17063)
  align perf tests with js (Azure#17069)
  [Perfstress][Storage] Added FileShare perf tests (Azure#15834)
  [formrecognizer] Adding custom forms perf test (Azure#16969)
  Fix LanguageShort typo (Azure#17068)
  sas creds updates (Azure#17065)
  [eventgrid] Fix Sample eh (Azure#17064)
  [Perfstress][Storage] Added Datalake perf tests (Azure#15861)
  [text analytics] Healthcare n-ary relations (Azure#16997)
  ServiceBus dict-representation acceptance and kwarg-update functionality  (Azure#14807)
  [text analytics] add perf tests (Azure#17060)
  Add cloud event to core (Azure#16800)
  [Perf] Small fixes to storage-blob (Azure#17055)
  [EG] Regenerate Code (Azure#17053)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
f66bdb4 
…into add_reprs

* 'master' of https://github.com/Azure/azure-sdk-for-python: (71 commits)
  EG - more docs imrpovement (Azure#17079)
  [EventHubs] add logging.info to warn the usage of partition key of non-string type (Azure#17057)
  march release (Azure#16966)
  Release of Device Update for IoT Hub SDK for Python. (Azure#17005)
  Add Get-AllPackageInfoFromRepo (Azure#16947)
  Track1 package is incorrectly set as track2 (Azure#17075)
  [text analytics] add normalized_text (Azure#17074)
  Renaming with_token identity function (Azure#17066)
  Adapt to azure core's cloud event (Azure#17063)
  align perf tests with js (Azure#17069)
  [Perfstress][Storage] Added FileShare perf tests (Azure#15834)
  [formrecognizer] Adding custom forms perf test (Azure#16969)
  Fix LanguageShort typo (Azure#17068)
  sas creds updates (Azure#17065)
  [eventgrid] Fix Sample eh (Azure#17064)
  [Perfstress][Storage] Added Datalake perf tests (Azure#15861)
  [text analytics] Healthcare n-ary relations (Azure#16997)
  ServiceBus dict-representation acceptance and kwarg-update functionality  (Azure#14807)
  [text analytics] add perf tests (Azure#17060)
  Add cloud event to core (Azure#16800)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
bf5990f 
…into http_response_json

* 'master' of https://github.com/Azure/azure-sdk-for-python: (165 commits)
  EG - more docs imrpovement (Azure#17079)
  [EventHubs] add logging.info to warn the usage of partition key of non-string type (Azure#17057)
  march release (Azure#16966)
  Release of Device Update for IoT Hub SDK for Python. (Azure#17005)
  Add Get-AllPackageInfoFromRepo (Azure#16947)
  Track1 package is incorrectly set as track2 (Azure#17075)
  [text analytics] add normalized_text (Azure#17074)
  Renaming with_token identity function (Azure#17066)
  Adapt to azure core's cloud event (Azure#17063)
  align perf tests with js (Azure#17069)
  [Perfstress][Storage] Added FileShare perf tests (Azure#15834)
  [formrecognizer] Adding custom forms perf test (Azure#16969)
  Fix LanguageShort typo (Azure#17068)
  sas creds updates (Azure#17065)
  [eventgrid] Fix Sample eh (Azure#17064)
  [Perfstress][Storage] Added Datalake perf tests (Azure#15861)
  [text analytics] Healthcare n-ary relations (Azure#16997)
  ServiceBus dict-representation acceptance and kwarg-update functionality  (Azure#14807)
  [text analytics] add perf tests (Azure#17060)
  Add cloud event to core (Azure#16800)
  ...
@dpokluda dpokluda deleted the device-update branch March 5, 2021 01:24
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 5, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
f297542 
…into assertions

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [core] add HttpRequest and HttpResponse reprs (Azure#16972)
  [text analytics] add actual normalized_text tests (Azure#17123)
  update samples to use actual role names (Azure#17124)
  Sync eng/common directory with azure-sdk-tools for PR 1448 (Azure#17085)
  Enable APIView status check (Azure#17107)
  Fix PackageName typo (Azure#17109)
  Move SetTestPipelineVersion.ps1 to eng/common (Azure#17103)
  Fix paths for non-windows agents (Azure#17096)
  [Communication] - Identity - Update README (Azure#17091)
  Rename CertificateCredential's certificate_bytes -> certificate_data (Azure#17090)
  fix shared reqs (Azure#17095)
  [translation] initial library (Azure#16837)
  EG - more docs imrpovement (Azure#17079)
  [EventHubs] add logging.info to warn the usage of partition key of non-string type (Azure#17057)
  march release (Azure#16966)
  Release of Device Update for IoT Hub SDK for Python. (Azure#17005)
  Add Get-AllPackageInfoFromRepo (Azure#16947)
  Track1 package is incorrectly set as track2 (Azure#17075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@iscai-msft iscai-msft iscai-msft approved these changes

@mayurid mayurid Awaiting requested review from mayurid

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@danieljurek danieljurek Awaiting requested review from danieljurek

@scbedd scbedd Awaiting requested review from scbedd

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpokluda @lmazuel @iscai-msft