Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Communication]: Enabled Phone Number Search Test #18247

Merged
merged 1 commit into from
Apr 23, 2021
Merged

[Communication]: Enabled Phone Number Search Test #18247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...nication/azure-communication-phonenumbers/test/test_phone_number_administration_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
SKIP_PURCHASE_PHONE_NUMBER_TESTS = True
PURCHASE_PHONE_NUMBER_TEST_SKIP_REASON = "Phone numbers shouldn't be purchased in live tests"

SKIP_SEARCH_AVAILABLE_PHONE_NUMBER_TESTS = True
SEARCH_AVAILABLE_PHONE_NUMBER_TEST_SKIP_REASON = "Temporarily skipping test"


class PhoneNumbersClientTest(CommunicationTestCase):
def setUp(self):
Expand Down Expand Up @@ -59,7 +56,6 @@ def test_get_purchased_phone_number(self):
phone_number = self.phone_number_client.get_purchased_phone_number(self.phone_number)
assert phone_number.phone_number == self.phone_number

@pytest.mark.skipif(SKIP_SEARCH_AVAILABLE_PHONE_NUMBER_TESTS, reason=SEARCH_AVAILABLE_PHONE_NUMBER_TEST_SKIP_REASON)
def test_search_available_phone_numbers_from_managed_identity(self):
endpoint, access_key = parse_connection_str(self.connection_str)
credential = create_token_credential()
Expand All @@ -77,7 +73,6 @@ def test_search_available_phone_numbers_from_managed_identity(self):
)
assert poller.result()

@pytest.mark.skipif(SKIP_SEARCH_AVAILABLE_PHONE_NUMBER_TESTS, reason=SEARCH_AVAILABLE_PHONE_NUMBER_TEST_SKIP_REASON)
def test_search_available_phone_numbers(self):
capabilities = PhoneNumberCapabilities(
calling = PhoneNumberCapabilityType.INBOUND,
Expand Down
5 changes: 0 additions & 5 deletions ...on/azure-communication-phonenumbers/test/test_phone_number_administration_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
SKIP_PURCHASE_PHONE_NUMBER_TESTS = True
PURCHASE_PHONE_NUMBER_TEST_SKIP_REASON = "Phone numbers shouldn't be purchased in live tests"

SKIP_SEARCH_AVAILABLE_PHONE_NUMBER_TESTS = True
SEARCH_AVAILABLE_PHONE_NUMBER_TEST_SKIP_REASON = "Temporarily skipping test"


class PhoneNumbersClientTestAsync(AsyncCommunicationTestCase):
def setUp(self):
Expand Down Expand Up @@ -74,7 +71,6 @@ async def test_get_purchased_phone_number(self):
phone_number = await self.phone_number_client.get_purchased_phone_number(self.phone_number)
assert phone_number.phone_number == self.phone_number

@pytest.mark.skipif(SKIP_SEARCH_AVAILABLE_PHONE_NUMBER_TESTS, reason=SEARCH_AVAILABLE_PHONE_NUMBER_TEST_SKIP_REASON)
@AsyncCommunicationTestCase.await_prepared_test
async def test_search_available_phone_numbers_from_managed_identity(self):
endpoint, access_key = parse_connection_str(self.connection_str)
Expand All @@ -94,7 +90,6 @@ async def test_search_available_phone_numbers_from_managed_identity(self):
)
assert poller.result()

@pytest.mark.skipif(SKIP_SEARCH_AVAILABLE_PHONE_NUMBER_TESTS, reason=SEARCH_AVAILABLE_PHONE_NUMBER_TEST_SKIP_REASON)
@AsyncCommunicationTestCase.await_prepared_test
async def test_search_available_phone_numbers(self):
capabilities = PhoneNumberCapabilities(
Expand Down