Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python to Spell Check dictionaries. #18695

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Add python to Spell Check dictionaries. #18695

merged 1 commit into from
Jul 1, 2021

Conversation

Lonanche
Copy link
Contributor

Some words like 'venv' or 'pylint' are not in the python dictionary so they are still gonna show up as a spell error.

Closes #18674

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 13, 2021
@ghost
Copy link

ghost commented May 13, 2021

Thank you for your contribution Lonanche! We will review the pull request and get back to you soon.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@lmazuel lmazuel requested a review from danieljurek July 1, 2021 16:27
@danieljurek
Copy link
Member

/azp run python - core - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@danieljurek
Copy link
Member

@danieljurek
Copy link
Member

/check-enforcer override

@danieljurek danieljurek merged commit 76ba4cf into Azure:main Jul 1, 2021
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cspell - add "python" language to cspell dictionaries list to prevent false positives in non-source files
2 participants