[Communication]Acs chat preview6 #19232
Conversation
LuChen-Microsoft
requested review from
ankitarorabit,
memontic-ms and
a team
as code owners
ghost
added
the
sdk/communication/azure-communication-chat/azure/communication/chat/_models.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/_chat_thread_client.py
Show resolved
Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/_chat_thread_client.py
Outdated
Show resolved
Hide resolved
...unication/azure-communication-chat/azure/communication/chat/aio/_chat_thread_client_async.py
Outdated
Show resolved
Hide resolved
| @@ -382,6 +384,7 @@ async def update_message( | |||
| self, | |||
| message_id: str, | |||
| content: str = None, | |||
| metadata: dict[str, str] = None, | |||
sdk/communication/azure-communication-chat/samples/chat_thread_client_sample_async.py
Show resolved
Hide resolved
| @@ -71,6 +71,7 @@ def __init__(self, method_name, *args, **kwargs): | |||
|
|
|||
| def setUp(self): | |||
| super(CommunicationTestCase, self).setUp() | |||
| print(111111) | |||
There was a problem hiding this comment.
Does this value have any signficance?
There was a problem hiding this comment.
@LuChen-Microsoft Please add tests for the metadata changes for the live tests as well. Other than that, looks good.
| @@ -394,6 +397,7 @@ def update_message( | |||
| self, | |||
| message_id, # type: str | |||
| content=None, # type: Optional[str] | |||
| metadata=None, # type: Optional[dict[str, str]] | |||
There was a problem hiding this comment.
Let's move this into kwargs, and document it as keyword only (same as we did for send_message)
There was a problem hiding this comment.
@annatisch do we need to also put content in kwargs? it's also optional.
There was a problem hiding this comment.
Depends on whether this library has already has a GA 1.0 release. If so - to move content into kwargs would be a breaking change.
sdk/communication/azure-communication-chat/azure/communication/chat/_models.py
Outdated
Show resolved
Hide resolved
...unication/azure-communication-chat/azure/communication/chat/aio/_chat_thread_client_async.py
Show resolved
Hide resolved
...unication/azure-communication-chat/azure/communication/chat/aio/_chat_thread_client_async.py
Show resolved
Hide resolved
| @@ -280,6 +280,7 @@ def send_message( | |||
| :paramtype chat_message_type: Union[str, ~azure.communication.chat.ChatMessageType] | |||
| :keyword str sender_display_name: The display name of the message sender. This property is used to | |||
| populate sender name for push notifications. | |||
| :keyword dict[str, str] metadata : Message metadata. | |||
There was a problem hiding this comment.
I don't see any updates to the SDK version - I presume this will be shipping as a new preview?
Also, could you please add some details to the changelog?
| @@ -403,6 +406,8 @@ def update_message( | |||
| :type message_id: str | |||
| :param content: Chat message content. | |||
| :type content: str | |||
| :param metadata: Message metadata. | |||
There was a problem hiding this comment.
This will need to be documented as keyword rather than param:
:keyword dict[str, str] metadata : Message metadata.
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## 1.0.1 (Unreleased) | |||
There was a problem hiding this comment.
This needs to be bumped to 1.1.0
|
/azp run python - communication - tests |
|
No pipelines are associated with this pull request. |
|
/azp run python - azure-communication-chat - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - azure-communication-chat - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - azure-communication-chat - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - azure-communication-chat - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* auto generated code * change the clients and tests * revert log change * fix review issues * use Dict instead of dict * disable the pylint too many instance check * fix comments * update changelog & move param into kwargs * update the version and the doc * revert version change * update the sdk version * update the sdk version with b1
ACSS & PHP public preview - version 1 and AMS V2 docs changes (Azure#19232) * Initial changes for ACSS, PHP workloads under Microsoft.Workloads and Updated Documentation for AMS V2 * updated custom words
No description provided.