-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Key Vault] Add 7.3-preview and random bytes API #19468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-generated source and supporting files LGTM
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
CloudService 2022-04-04 release (Azure#19468) * set up branch * Feature/cplat 2022 04 04 (Azure#19467) * set up feature branch * Update cloud service swagger file and examples (Azure#19311) * Update cloud service swagger file and examples * Update cloudService.json Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * move systemData object to common.json * Add CloudServiceSlotType to swagger api 2022-04-04 (Azure#19361) Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * update with prettier * resolve readme input * add missing example * fix example error, update common with latest change. * set up branch * change folder name * change folder name Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com> Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> * prettier fix Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com> Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
Resolves #19577. This adds the 7.3-preview API version, but doesn't include SKR at this time.
This skips 7.3-preview testing for a handful of test cases that require key import. These are currently blocked on an issue with key import on 7.3-preview on Key Vault.