-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support kind keyword in Opencensus #19548
Conversation
self._span_instance = span or tracer.start_span(name=name, **kwargs) | ||
if kind is not None: | ||
self._span_instance.span_kind = kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No handler for links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or it is handled in tracer.start_span?
if kind is not None: | ||
self._span_instance.span_kind = kind | ||
|
||
if links: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed links= kwargs.pop('links', None). :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have it in line 77
/check-enforcer override |
* support kind keyword * changelog * Unsupport kind * FIx kind kwarg support during instantiating * test * links * test fixx * update azure core * shared req
[Hub Generated] Publish private branch 'dev-msi-Microsoft.ManagedIdentity-2022-01-31-preview-federated-identities' (Azure#19548) * Adds base for updating Microsoft.ManagedIdentity from version stable/2018-11-30 to version 2022-01-31-preview * Updates readme * Updates API version in new specs and examples * Add associated resources preview API. See https://github.com/Azure/azure-rest-api-specs-pr/pull/4969 * Add federated identity credentials API * Incorporating changes from 'msi-associated-resources-preview-api-2021-09-30' * Examples default values are updated based on private preview feedback Co-authored-by: Yannick <6431099+natronq@users.noreply.github.com> Co-authored-by: Yannick Pobiega <ypobiega@microsoft.com> Co-authored-by: Igor Solenov <igorsolenov@microdoft.com>
Fixes #19364