Add OnBehalfOfCredential #20451
Merged
Add OnBehalfOfCredential #20451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
Client
This was referenced Aug 27, 2021
Closed
xiangyan99
reviewed
Aug 30, 2021
| :param str user_assertion: the access token the credential will use as the user assertion when requesting | ||
| on-behalf-of tokens | ||
|
|
||
| :keyword bool allow_multitenant_authentication: when True, enables the credential to acquire tokens from any tenant |
There was a problem hiding this comment.
If allow_multitenant_authentication is true, is tenant_id still required?
There was a problem hiding this comment.
Yes, if only to identify a tenant the service principal is registered in.
xiangyan99
reviewed
Aug 30, 2021
| _LOGGER = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class OnBehalfOfCredential: |
There was a problem hiding this comment.
Do we want to inherit from abc.ABC?
There was a problem hiding this comment.
I don't think so. Should this class have an abstract method?
There was a problem hiding this comment.
Sorry. I meant AsyncContextManager. I need some coffee. :)
There was a problem hiding this comment.
Right you are. I needed coffee when I wrote this 💤
xiangyan99
approved these changes
Sep 1, 2021
mccoyp
approved these changes
Sep 1, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Sep 7, 2021
…into switch_to_protocol * 'main' of https://github.com/Azure/azure-sdk-for-python: (53 commits) Smoke test package verification (Azure#20547) Update CHANGELOG.md (Azure#20569) updating codeowners (Azure#20570) Simplify recorded OnBehalfOfCredential tests (Azure#20568) Search: update release date (Azure#20564) [Exporter] Support redirect response in exporter (Azure#20489) [AutoRelease] t2-synapse-2021-09-06-18774 (Azure#20552) [AutoRelease] t2-logz-2021-08-26-01773 (Azure#20426) [AutoRelease] t2-relay-2021-09-03-32777 (Azure#20530) [AutoRelease] t2-resource-2021-09-03-61345 (Azure#20527) [AutoRelease] t2-servicefabric-2021-09-02-41879 (Azure#20512) [Keyvault] Remove exception message parsing from samples in keys, certificates and secrets (Azure#20540) [ACR] Update cloud configuration API (Azure#20464) Get rid of generated code (Azure#20536) Search: Skill Versions (Azure#20431) Check fd is reg file or symlink in get_length before using st_size. (Azure#19725) Add OnBehalfOfCredential (Azure#20451) Fix incorrect parsing of message from Exception (Azure#20534) [Release sdk status] swagger repo default branch changes to `main` (Azure#20529) [AutoRelease] t2-rdbms-2021-09-02-91864 (Azure#20513) ...
iscai-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19308