remove iter_text and iter_lines #20460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
xiangyan99
reviewed
Aug 30, 2021
| request = HttpRequest("GET", "/basic/string") | ||
| # @pytest.mark.asyncio | ||
| # async def test_iter_text(client): | ||
| # request = HttpRequest("GET", "/basic/string") |
There was a problem hiding this comment.
Why we comment these out rather than removing them?
Does that mean we plan to add them back in the future?
There was a problem hiding this comment.
Yeah, planning to add them back in the future. I can delete if people want to remove the tests
There was a problem hiding this comment.
i was just feeling attached so didn't want to delete
There was a problem hiding this comment.
Then maybe we can just skip the tests w/ some reasons.
It can help us in the future to understand what happened.
xiangyan99
reviewed
Aug 30, 2021
|
|
||
| async with client.send_request(request, stream=True) as response: | ||
| async for line in response.iter_lines(): | ||
| async for line in response.iter_bytes(): |
There was a problem hiding this comment.
Do you still want to use "line"? It is up to you. :)
There was a problem hiding this comment.
I'm getting rid of iter_lines so can't use it anymore, switching to iter_bytes instead
There was a problem hiding this comment.
What I meant was
async for line in response.iter_bytes():
:)
There was a problem hiding this comment.
ohh i see, yeah will get rid
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 31, 2021
…into switch_to_protocol * 'main' of https://github.com/Azure/azure-sdk-for-python: release_iseus_status_auto_reply (Azure#20441) Clarify LogsQueryClient query parameter description (Azure#20467) Sync eng/common directory with azure-sdk-tools for PR 1953 (Azure#20466) Skip eng common workflow enforcer for private repos (Azure#20462) remove iter_text and iter_lines (Azure#20460)
iscai-msft
added a commit
that referenced
this pull request
Aug 31, 2021
…into header_tuples * 'main' of https://github.com/Azure/azure-sdk-for-python: (21 commits) [Key Vault] Add 7.3-preview support for certificates (#20477) Use dummy values and correct code rendering in README (#20322) Use CredScan-suppressed dummy password in sample (#20468) Fix type annotation in azure.storage.blob (#20084) Adding static checks (#20457) release_iseus_status_auto_reply (#20441) Clarify LogsQueryClient query parameter description (#20467) Sync eng/common directory with azure-sdk-tools for PR 1953 (#20466) Skip eng common workflow enforcer for private repos (#20462) remove iter_text and iter_lines (#20460) [ServiceBus] Improve test stability and cpu usage (#20352) t2-Netapp-update-to-2021-06-01 (#20453) [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423) Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450) New dummy password in README (#20328) ensure test principal creation succeeds properly (#20446) Update question-answering readme links (#20439) Stip empty changelog sections before release (#20437) [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422) [AutoRelease] t2-iothub-2021-08-25-25696 (#20409) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 31, 2021
…into update_lro_paging * 'main' of https://github.com/Azure/azure-sdk-for-python: [Core] Follow RFC 3339 datetime formatting for AzureJSONEncoder (Azure#20346) [Key Vault] Add 7.3-preview support for certificates (Azure#20477) Use dummy values and correct code rendering in README (Azure#20322) Use CredScan-suppressed dummy password in sample (Azure#20468) Fix type annotation in azure.storage.blob (Azure#20084) Adding static checks (Azure#20457) release_iseus_status_auto_reply (Azure#20441) Clarify LogsQueryClient query parameter description (Azure#20467) Sync eng/common directory with azure-sdk-tools for PR 1953 (Azure#20466) Skip eng common workflow enforcer for private repos (Azure#20462) remove iter_text and iter_lines (Azure#20460)
iscai-msft
added a commit
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have an issue to add it back eventually #20459